Repository navigation
Primer branding: use sentence case for header and CTA copy - #324
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Voice and tone
src/index.html: changed the header subtitle from "Add Agentic Automation to your Repository in minutes" to "Add agentic automation to your repository in minutes".src/index.html: changed the primary CTA label from "Create Your Agentic Workflow" to "Create your agentic workflow".test/e2e/smoke.spec.js,test/e2e/web-llm.spec.js) that locate the CTA by its accessible name, so they keep passing against the new copy.Brand guidance that motivated this change
Every Primer Brand (
@primer/react-brand) component example I retrieved via theprimer-brandMCP server (Button, Hero, CTA banner, CTA form, Card) uses sentence case for interactive and heading text — e.g. the canonical Button example readsPrimary action, notPrimary Action. The two strings above were the only Title Case instances in the markup (confirmed via a full scan withgrep -noE '>[A-Z][a-z]+ [A-Z][a-z]+[^<]*<'), and they were inconsistent with the rest of the site's own established sentence-case convention (e.g. "Copy prompt", "Got it", "Report an issue", "Run evals"). This was the most clear-cut, lowest-risk deviation found.Audit notes — deviations considered but not changed
src/styles/style.css(light + dark mode): body text, muted text, accent-blue links, and all six label colors (--label-blue/purple/green/orange/pink/gray) pass AA (ratios 4.67–17.04, lowest being--label-greenon white at 5.08:1 — still above the 4.5:1 AA text threshold). No contrast violations found, so no color changes were made.Heading/Textcomponents use lighter display weights (~440–480) for marketing headings, versus this site's bold (700) weights forh1and step/status labels. I did not change this: the site is a product-like wizard UI (progress steps, GitHub-style labels) rather than a marketing page built from BrandHero/Headingcomponents, so bold condensed UI labels are the appropriate pattern here (consistent with GitHub's own product issue/PR label treatment), not a deviation from Brand's marketing-page type scale.primer_brand_reviewflagged that no@primer/react-brandcomponents are used and suggested rebuilding with them. Per the task's explicit constraints, I did not restructure the page or swap@primer/cssfor@primer/react-brand— this repo intentionally uses Primer's product CSS, not the Brand marketing component library.--radius-md/--radius-lg(mapped to--borderRadius-medium/-large, 8px/12px) and the existing landing-page radial gradient/shine accents — all derive from this site's own accent-blue token family and pass contrast, so left untouched per the "tasteful shine is allowed" guidance.Verification
npm test— 329/329 tests passed (19 test files), including the updated e2e specs' accessible-name assertions.npm run build— build succeeded (Vite), producingdist/without errors.No other files were changed. No application logic, ARIA attributes, or file structure were modified.
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
registry.npmjs.orgunpkg.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.