Repository navigation
Primer branding: fix mismatched RGB tokens for accent/agent colors - #321
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed (color)
src/styles/style.cssdefines--accent-blue-rgb,--agent-purple-rgb, and (light theme)--accent-green-rgbas RGB triplets meant to be used asrgba(var(--...-rgb), alpha)alongside their paired hex custom properties (--accent-blue,--agent-purple,--accent-green). The RGB triplets did not actually match the hex values they were paired with:--accent-blue/--agent-purple(light)#5f489a116, 88, 18195, 72, 154--accent-blue/--agent-purple(dark)#c3b5e4166, 147, 212195, 181, 228--accent-green(light)#1a7f3746, 160, 6726, 127, 55(Dark-theme
--accent-green-rgbalready matched#2ea043and was left unchanged.)I retrieved GitHub's Primer Brand color scale (
primer_brand_docs→ Color primitives andprimer_brand_tokens) and confirmed#5f489a/#c3b5e4sit in the purple scale and#1a7f37/#2ea043in the green scale — so the paired hex values were already on-brand, but the stray RGB numbers (closer to--border-focus's own color) meant every semi-transparent overlay using these tokens rendered an incorrect, off-brand tint instead of the intended accent hue.These mismatched triplets are consumed in ~20 places across
style.css: focus rings, hover/active backgrounds on buttons and option cards, the "info callout" tint, the landing-page dithered dot background (radial-gradient(circle, rgba(var(--accent-blue-rgb), 0.28) ...)), the assistant modal's celebration rings/sparks/glow, and the pulsing "completed" step indicator. All of these now render the correct, intended brand accent color in both light and dark themes instead of a slightly-shifted one.Deviations found but not fixed (documented, not applied)
@primer/react-brand) is designed for marketing pages, not for a utility app UI like this wizard, so wholesale token substitution risked a large, risky diff for presentational code this task says to keep small. I left this as a candidate follow-up rather than bundling it here.999px"pill" radius on.btn-get-startedand50%circular radii elsewhere are intentional shapes (full capsule/circle), not approximations of a square-cornered Primer radius token, so I left them alone.box-shadow: 0 0 12px rgba(var(--agent-purple-rgb), 0.8)) is a tasteful one-color accent built entirely from the (now-corrected) brand purple token, so per the task's guidance on allowed "tasteful shine," I kept it rather than removing it.Verification
npm test— 329/329 tests passed.npm run build(viavite build, since the vendor-asset download step is blocked by this sandbox's network policy and unrelated to this change) — built successfully with no errors.This is a minimal, surgical color-correctness fix: 6 lines changed, no markup/logic changes, no new dependencies.
Warning
Firewall blocked 3 domains
The following domains were blocked by the firewall during workflow execution:
cdn.jsdelivr.netregistry.npmjs.orgunpkg.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.