Repository navigation
Port implementation status and lazy snapshots from #460 - #512
Open
MaggieAppleton wants to merge 3 commits into
Open
MaggieAppleton wants to merge 3 commits into
MaggieAppleton wants to merge 3 commits into
Conversation
MaggieAppleton
marked this pull request as ready for review
October 12, 2026 11:00
plan:implementation and the plan:open reply now carry hasGraph, derived from the latest graph version, so clients can tell a graph exists without fetching a full implementation snapshot. Ported from #460. Co-authored-by: Krzysztof Cieslak <krzysztof_cieslak@windowslive.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
useImplementationSnapshot fetches the full snapshot only while an implementation view is active, ignores stale responses by room and revision, and refreshes on the frames its caller names. The shared Build plan state (useBuildPlan, behind the header capsule, the Build tab and the Build view) adopts it in place of its inline fetch and reload logic, with the same behaviour: the same reload frames, the throttled edit reload, and the fresh read after a draft turn ends. Ported from #460. Co-authored-by: Krzysztof Cieslak <krzysztof_cieslak@windowslive.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaggieAppleton
force-pushed
the
port-460-snapshot
branch
from
October 12, 2026 18:20
b3fa6db to
25be76b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports two backend pieces from @Krzysztof-Cieslak's #460. Both commits carry his co-author trailer.
#460 will be closed. Its interactive task-graph UI and workspace picker are superseded: the team chose #508's Build capsule and view, and #451's rule that work runs on whoever clicks Build. These two pieces stand on their own and are worth keeping.
What is kept
hasGraphon implementation status.Plan.ImplementationStatus(protocol first) gainshasGraph: boolean, andimplementationStatus()derives it from the latest graph version's tasks. It rides onplan:implementationand theplan:openreply, so a client can tell a graph exists without fetching a full snapshot. Krzysztof's test checks that it publishes only after the durable commit and survives reopening.useImplementationSnapshot(apps/web/src/implementation-snapshot.ts). Full snapshots load only while an implementation view is active, and responses for another room or an older revision are ignored. It refreshes on the frames its caller names (by defaultplan:implementation,plan:open,plan:updateandexperiment:changed) and exposesread()for an immediate fresh read. After the rebase onto main, Make Build plan explicit and show build status in one capsule #508 loads Build's snapshot inuseBuildPlan(build-plan-button.tsx), which the header capsule, the Build tab and the Build view all share.useBuildPlannow uses the hook in place of its inline fetch and reload logic, with the same behaviour: the same reload frames, the throttled reload on edits, and the fresh read after a draft turn ends.implementationResponseandimplementationEndpointstay inbuild-start.ts.hasGraphhas no consumer yet: room-workspace'splan:implementationhandler only useslocked, and Build reads the full snapshot. It is left as an available field (room-workspace's initial status just includeshasGraph: false).Merge order
This merges after the living-document stack (#451 → #452 → #453 → #508 → #510/#454 → #457 → #466 → #520), which has now landed. It has been rebased onto main, and the hook is adopted in #508's shared Build state rather than in
build-view.tsx, which no longer fetches snapshots itself.flowchart LR A[Build view active?] -- no --> Z[No fetch; in-flight request aborted] A -- yes --> F[GET /api/channels/:room/implementation] F --> S{Same room and older revision?} S -- yes --> X[Ignore stale response] S -- no --> U[Set snapshot, call onLoad] W[plan:implementation / plan:open / plan:update / experiment:changed] --> R[refresh: abort current, refetch] R --> FTests
bun test apps/server/src/tasks apps/web/src/build*(69 pass, includes newnotifications.test.ts)bun testfull: all pass except three design-token/icon audits that flag local, uncommitted design-jig filesbun run typescleanbun run ci: only a design-jig CSS custom-property finding (local jig file, not in this PR)bun run e2e e2e/implementation-launcher.e2e.ts: 11 passed, 1 skipped🤖 Generated with Claude Code