[Crane: crane-migration-python-to-go-full-apm-cli-rewrite]#104
Open
github-actions[bot] wants to merge 2 commits into
Open
[Crane: crane-migration-python-to-go-full-apm-cli-rewrite]#104github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
…35: Register PR #103 tests in coverage manifest Changes: - Add 5 new tests from PR #103 (crane completion gating) to python_contract_coverage.yml - Fixes python_behavior_contracts gate failing (unknown tests not mapped as obsolete) - All 10/10 deletion-grade gates now pass, migration_score=1.0 Run: https://github.com/githubnext/apm/actions/runs/26899293692 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
Migration Benchmark Results
Migration CLI BenchmarkMax allowed Go/Python median ratio:
|
This was referenced Jun 3, 2026
Open
Contributor
|
This PR should not be treated as final completion for #78 yet. The reported Python-vs-Go parity pass is useful, but the migration's completion gate now requires:
Until that Go-vs-golden/no-Python gate exists and passes, #78 should remain active and should not carry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[bot] This PR is maintained by Crane. Each accepted iteration adds a commit to this branch.
Python -> Go Migration (greenfield)
Source:
src/apm_cli/(Python 3.10+)Target:
cmd/apm/,internal/(Go)Strategy: greenfield
Migration Issue: #78
Iteration 35 -- Register PR #103 tests in coverage manifest
PR #103 ("Fix Crane completion gating") added 5 new Python unit tests that were not registered in
tests/parity/python_contract_coverage.yml. This caused thepython_behavior_contractsdeletion-grade gate to fail, blockingmigration_score=1.0.Fix: Register all 5 tests as obsolete entries in the coverage manifest:
test_crane_scheduler.py::test_issue_label_detection_accepts_github_label_payloadstest_crane_scheduler.py::test_pr_head_gate_fails_when_any_check_is_not_successtest_crane_scheduler.py::test_pr_head_gate_passes_only_when_all_checks_succeedtest_crane_workflow_prompt.py::test_crane_completion_is_two_phase_and_pr_head_gatedtest_crane_workflow_prompt.py::test_crane_state_template_tracks_completion_candidate_gateVerification result: All 10/10 deletion-grade gates pass,
migration_score=1.0.Score: 1.0 | Progress: 476/476 parity tests | Go tests: 498 passing | Python tests: 247 passing
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
bitbucket.example.comSee Network Configuration for more information.