Skip to content

fix(claude): refresh members after routing, clearer health dirs, no retired logs, plugin validates clean (#2456, #2455, #2454, #2458) - #2471

Merged
bradygaster merged 3 commits into
devfrom
squad/2456-2455-2454-claude-polish
Nov 12, 2026
Merged

bradygaster merged 3 commits into
devfrom
squad/2456-2455-2454-claude-polish

Conversation

@bradygaster

@bradygaster bradygaster commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Claude Code follow-ups from the end-to-end test (epic #2438, checklist #2469).

Closes #2456
Closes #2455
Closes #2454
Closes #2458

#2456: member descriptions after routing

squad cast writes .claude/agents/<member>.md straight away, but Init Mode writes routing.md afterwards, so descriptions stayed at "Owns: " until squad upgrade. Claude Code uses that description to decide when to delegate.

  • New squad client sync [--dry-run] re-projects the hosts already configured in .squad/config.json, rewriting only Squad-managed files. It's a no-op when no host is configured.
  • The coordinator's Init Mode (Phase 2) now runs squad client sync once routing.md is written. The plugin's generated copy is rebuilt and still pinned to 2.0.0-preview.4.
  • Help text, the main help line, and the multi-client guide all cover it.

#2455: health directories

resolvedTeamDir holds the team root (the directory that contains .squad), which reads like the squad directory. Renaming it would break squad-state-health/v1 consumers, so both squad_state_health and squad health --json keep it as is and add:

  • resolvedTeamRoot: the same value, correctly named.
  • resolvedSquadDir: the squad directory itself.

The CLI reference documents all three.

#2454: Scribe and the retired logs

The Claude coordinator digest (item 11) asked Scribe to append session and orchestration logs. Scribe's charter and the Copilot coordinator both retired them, so Scribe refused. The digest now says neither Scribe nor the coordinator writes them, and the behavioural-contract parity test pins the new rule instead of the old orchestration-log/ / /log/ paths.

Plugin skill frontmatter and #2458

  • The cli-wiring and retro-enforcement template skills get frontmatter, so claude plugin validate plugins/squad passes with no warnings. The edit is in .squad-templates/ and its package mirrors; templates/ gets only these two files, because its other files have drifted.
  • squad init --client claude also writes .copilot, .github and .vscode: intended? #2458: squad init --client claude also writing the Copilot files is intended. Copilot is the base host, and .github/agents/squad.agent.md is the canonical coordinator (ADR-003 proposes otherwise). client-compatibility.md now says so, along with how to skip the optional parts.

Testing

  • New in test/claude-members.test.ts: cast, then write routing.md, then squad client sync --dry-run (no change), then squad client sync (the description gains "Owns: … Payments API"). Also a sync with no host configured, which writes nothing.
  • Updated: the state-mcp health metadata expectation, and the coordinator parity regexes.
  • Help, coordinator, digest, host-matrix and projection suites: 1,464 passed. The 2 failures are the squad-20 bridge scenarios that fail identically on a clean origin/dev.
  • npm run lint is clean, and the plugin --check is current. Markdownlint and cspell are clean for the changed docs.

Changeset and [Unreleased] entries are included; there's no version bump.

🤖 Generated with Claude Code

…etired logs (#2456, #2455, #2454)

- #2456: `squad client sync` re-projects the configured hosts. Init Mode
  runs it once routing.md is written, so Claude member subagent
  descriptions carry "Owns: …" from routing instead of the role alone.
- #2455: health metadata (squad_state_health, squad health --json) adds
  resolvedTeamRoot and resolvedSquadDir; resolvedTeamDir keeps its
  value (the team root) for squad-state-health/v1 consumers.
- #2454: the coordinator digest no longer asks Scribe for session and
  orchestration logs, matching Scribe's charter and the Copilot
  coordinator; the parity test pins the new rule.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI adaptive review requested due to automatic review settings November 12, 2026 04:41
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🟠 Impact Analysis — PR #2471

Risk tier: 🟠 HIGH

📊 Summary

Metric Count
Files changed 26
Files added 1
Files modified 25
Files deleted 0
Modules touched 6
Critical files 1

🎯 Risk Factors

  • 26 files changed (21-50 → HIGH)
  • 6 modules touched (5-8 → HIGH)
  • Critical files touched: packages/squad-sdk/src/tools/index.ts

📦 Modules Affected

docs (3 files)
  • docs/src/content/docs/reference/cli.md
  • docs/src/content/docs/scenarios/client-compatibility.md
  • docs/src/content/docs/scenarios/using-squad-across-clients.md
root (8 files)
  • .changeset/claude-polish.md
  • CHANGELOG.md
  • plugins/squad/agents/squad.md
  • plugins/squad/skills/cli-wiring/SKILL.md
  • plugins/squad/skills/retro-enforcement/SKILL.md
  • plugins/squad/skills/squad-coordinator-init-mode/SKILL.md
  • templates/skills/cli-wiring/SKILL.md
  • templates/skills/retro-enforcement/SKILL.md
squad-cli (6 files)
  • packages/squad-cli/src/cli-entry.ts
  • packages/squad-cli/src/cli/commands/client.ts
  • packages/squad-cli/src/cli/commands/health.ts
  • packages/squad-cli/src/cli/core/command-help.ts
  • packages/squad-cli/templates/skills/cli-wiring/SKILL.md
  • packages/squad-cli/templates/skills/retro-enforcement/SKILL.md
squad-sdk (4 files)
  • packages/squad-sdk/src/client/adapters/coordinator.ts
  • packages/squad-sdk/src/tools/index.ts
  • packages/squad-sdk/templates/skills/cli-wiring/SKILL.md
  • packages/squad-sdk/templates/skills/retro-enforcement/SKILL.md
templates (2 files)
  • .squad-templates/skills/cli-wiring/SKILL.md
  • .squad-templates/skills/retro-enforcement/SKILL.md
tests (3 files)
  • test/claude-members.test.ts
  • test/cli/state-mcp.test.ts
  • test/clients.test.ts

⚠️ Critical Files

  • packages/squad-sdk/src/tools/index.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 6cb4593

PR Scope: 📦🔧 Mixed (product + infrastructure)

⚠️ 3 item(s) to address before review

Status Check Details
❌ Single commit 3 commits — consider squashing before review
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present Changeset file found
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
❌ Copilot threads resolved 1 unresolved Copilot thread(s) — fix and resolve before merging
✅ CI passing All checks passing

Files Changed (26 files, +178 −11)

File +/−
.changeset/claude-polish.md +10 −0
.squad-templates/skills/cli-wiring/SKILL.md +8 −0
.squad-templates/skills/retro-enforcement/SKILL.md +8 −0
CHANGELOG.md +3 −0
docs/src/content/docs/reference/cli.md +1 −1
docs/src/content/docs/scenarios/client-compatibility.md +2 −0
docs/src/content/docs/scenarios/using-squad-across-clients.md +6 −0
packages/squad-cli/src/cli-entry.ts +1 −1
packages/squad-cli/src/cli/commands/client.ts +25 −1
packages/squad-cli/src/cli/commands/health.ts +7 −0
packages/squad-cli/src/cli/core/command-help.ts +5 −3
packages/squad-cli/templates/skills/cli-wiring/SKILL.md +8 −0
packages/squad-cli/templates/skills/retro-enforcement/SKILL.md +8 −0
packages/squad-sdk/src/client/adapters/coordinator.ts +2 −2
packages/squad-sdk/src/tools/index.ts +6 −0
packages/squad-sdk/templates/skills/cli-wiring/SKILL.md +8 −0
packages/squad-sdk/templates/skills/retro-enforcement/SKILL.md +8 −0
plugins/squad/agents/squad.md +1 −1
plugins/squad/skills/cli-wiring/SKILL.md +7 −0
plugins/squad/skills/retro-enforcement/SKILL.md +7 −0
plugins/squad/skills/squad-coordinator-init-mode/SKILL.md +1 −1
templates/skills/cli-wiring/SKILL.md +8 −0
templates/skills/retro-enforcement/SKILL.md +8 −0
test/claude-members.test.ts +26 −0
test/cli/state-mcp.test.ts +2 −0
test/clients.test.ts +2 −1

Total: +178 −11


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🏗️ Architectural Review

Authoritative evidence: scanners from the PR base commit, posted by the default-branch workflow_run reporter.
Results for head commit 6cb4593e1d29d9d734c935eedf6bf9e995eeaf15.

⚠️ Architectural review: 2 warning(s).

Severity Category Finding Files
🟡 warning bootstrap-area 1 file(s) in the bootstrap area (packages/squad-cli/src/cli/core/) were modified. These files must maintain zero external dependencies. Review carefully. packages/squad-cli/src/cli/core/command-help.ts
🟡 warning sweeping-refactor This PR touches 26 files (26 modified/added, 0 deleted). Large PRs are harder to review — consider splitting if possible. —

Automated architectural review — informational only.

// subagent descriptions are built from it. Only Squad-managed files are rewritten.
try {
const squadDir = detectSquadDir(dest).path;
const synced = await syncClients(dest, squadDir, { dryRun, warn: (m) => console.warn(m) });
*/
resolvedTeamDir: resolvedTeamDirectory(this.squadRoot),
resolvedTeamRoot: resolvedTeamDirectory(this.squadRoot),
resolvedSquadDir: path.resolve(this.squadRoot),
…ase files (#2458)

- cli-wiring and retro-enforcement get name/description frontmatter in
  .squad-templates and their two package mirrors (templates/, whose
  other files have drifted, gets these two only). `claude plugin
  validate plugins/squad` now passes with no warnings.
- client-compatibility.md says why `squad init --client claude` also
  writes the GitHub Copilot files: Copilot is the base host and
  .github/agents/squad.agent.md the canonical coordinator (ADR-003
  proposes otherwise), with --no-workflows / --no-vscode-default to
  skip the optional parts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bradygaster bradygaster changed the title fix(claude): refresh members after routing, clearer health dirs, no retired logs (#2456, #2455, #2454) fix(claude): refresh members after routing, clearer health dirs, no retired logs, plugin validates clean (#2456, #2455, #2454, #2458) Nov 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Running squad client sync from a repository subdirectory without SQUAD_TEAM_ROOT reads configuration from the wrong location and exits successfully without updating member descriptions.

1 open issue
What changed in this PR

Addresses three Claude Code follow-ups: refreshing member descriptions after routing changes, clarifying health-report paths, and aligning coordinator instructions with retired logging behavior.

Changes:

  • Adds squad client sync [--dry-run] and invokes it after Init Mode writes routing.
  • Adds explicit team-root and squad-directory health fields while preserving compatibility.
  • Removes requests for retired logs and updates tests, documentation, and release notes.
File Description
test/​clients.test.ts Updates the coordinator logging contract assertion.
test/​cli/​state-mcp.test.ts Checks the new health metadata fields.
test/​claude-members.test.ts Covers routing refresh, dry-run, and no-host behavior.
plugins/​squad/​skills/​squad-coordinator-init-mode/​SKILL.md Adds post-routing sync to plugin instructions.
plugins/​squad/​agents/​squad.md Removes retired logging requirements.
packages/​squad-sdk/​src/​tools/​index.ts Adds explicit paths to MCP health metadata.
packages/​squad-sdk/​src/​client/​adapters/​coordinator.ts Updates initialization and Scribe instructions.
packages/​squad-cli/​src/​cli/​core/​command-help.ts Documents sync and its dry-run option.
packages/​squad-cli/​src/​cli/​commands/​health.ts Adds explicit paths to CLI health metadata.
packages/​squad-cli/​src/​cli/​commands/​client.ts Implements the sync subcommand.
packages/​squad-cli/​src/​cli-entry.ts Lists sync in top-level help.
docs/​src/​content/​docs/​scenarios/​using-squad-across-clients.md Explains refreshing configured host files.
docs/​src/​content/​docs/​reference/​cli.md Clarifies health path fields and compatibility.
CHANGELOG.md Records the three follow-up changes.
.changeset/​claude-polish.md Declares SDK and CLI patch releases.

Review effort: Balanced (auto)

Comment on lines +161 to +162
const squadDir = detectSquadDir(dest).path;
const synced = await syncClients(dest, squadDir, { dryRun, warn: (m) => console.warn(m) });
}

console.error(`❌ Unknown client subcommand: ${sub}\n Usage: squad client list [--json] | squad client add <list> [--dry-run]`);
if (sub === 'sync') {
@bradygaster
bradygaster merged commit 47082a8 into dev Nov 12, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants