Repository navigation
fix(claude): refresh members after routing, clearer health dirs, no retired logs, plugin validates clean (#2456, #2455, #2454, #2458) - #2471
Conversation
…etired logs (#2456, #2455, #2454) - #2456: `squad client sync` re-projects the configured hosts. Init Mode runs it once routing.md is written, so Claude member subagent descriptions carry "Owns: …" from routing instead of the role alone. - #2455: health metadata (squad_state_health, squad health --json) adds resolvedTeamRoot and resolvedSquadDir; resolvedTeamDir keeps its value (the team root) for squad-state-health/v1 consumers. - #2454: the coordinator digest no longer asks Scribe for session and orchestration logs, matching Scribe's charter and the Copilot coordinator; the parity test pins the new rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🟠 Impact Analysis — PR #2471Risk tier: 🟠 HIGH 📊 Summary
🎯 Risk Factors
📦 Modules Affecteddocs (3 files)
root (8 files)
squad-cli (6 files)
squad-sdk (4 files)
templates (2 files)
tests (3 files)
|
🛫 PR Readiness Check
PR Scope: 📦🔧 Mixed (product + infrastructure)
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 3 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ❌ | Copilot threads resolved | 1 unresolved Copilot thread(s) — fix and resolve before merging |
| ✅ | CI passing | All checks passing |
Files Changed (26 files, +178 −11)
| File | +/− |
|---|---|
.changeset/claude-polish.md |
+10 −0 |
.squad-templates/skills/cli-wiring/SKILL.md |
+8 −0 |
.squad-templates/skills/retro-enforcement/SKILL.md |
+8 −0 |
CHANGELOG.md |
+3 −0 |
docs/src/content/docs/reference/cli.md |
+1 −1 |
docs/src/content/docs/scenarios/client-compatibility.md |
+2 −0 |
docs/src/content/docs/scenarios/using-squad-across-clients.md |
+6 −0 |
packages/squad-cli/src/cli-entry.ts |
+1 −1 |
packages/squad-cli/src/cli/commands/client.ts |
+25 −1 |
packages/squad-cli/src/cli/commands/health.ts |
+7 −0 |
packages/squad-cli/src/cli/core/command-help.ts |
+5 −3 |
packages/squad-cli/templates/skills/cli-wiring/SKILL.md |
+8 −0 |
packages/squad-cli/templates/skills/retro-enforcement/SKILL.md |
+8 −0 |
packages/squad-sdk/src/client/adapters/coordinator.ts |
+2 −2 |
packages/squad-sdk/src/tools/index.ts |
+6 −0 |
packages/squad-sdk/templates/skills/cli-wiring/SKILL.md |
+8 −0 |
packages/squad-sdk/templates/skills/retro-enforcement/SKILL.md |
+8 −0 |
plugins/squad/agents/squad.md |
+1 −1 |
plugins/squad/skills/cli-wiring/SKILL.md |
+7 −0 |
plugins/squad/skills/retro-enforcement/SKILL.md |
+7 −0 |
plugins/squad/skills/squad-coordinator-init-mode/SKILL.md |
+1 −1 |
templates/skills/cli-wiring/SKILL.md |
+8 −0 |
templates/skills/retro-enforcement/SKILL.md |
+8 −0 |
test/claude-members.test.ts |
+26 −0 |
test/cli/state-mcp.test.ts |
+2 −0 |
test/clients.test.ts |
+2 −1 |
Total: +178 −11
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
🏗️ Architectural Review
Automated architectural review — informational only. |
| // subagent descriptions are built from it. Only Squad-managed files are rewritten. | ||
| try { | ||
| const squadDir = detectSquadDir(dest).path; | ||
| const synced = await syncClients(dest, squadDir, { dryRun, warn: (m) => console.warn(m) }); |
| */ | ||
| resolvedTeamDir: resolvedTeamDirectory(this.squadRoot), | ||
| resolvedTeamRoot: resolvedTeamDirectory(this.squadRoot), | ||
| resolvedSquadDir: path.resolve(this.squadRoot), |
…ase files (#2458) - cli-wiring and retro-enforcement get name/description frontmatter in .squad-templates and their two package mirrors (templates/, whose other files have drifted, gets these two only). `claude plugin validate plugins/squad` now passes with no warnings. - client-compatibility.md says why `squad init --client claude` also writes the GitHub Copilot files: Copilot is the base host and .github/agents/squad.agent.md the canonical coordinator (ADR-003 proposes otherwise), with --no-workflows / --no-vscode-default to skip the optional parts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Running squad client sync from a repository subdirectory without SQUAD_TEAM_ROOT reads configuration from the wrong location and exits successfully without updating member descriptions.
1 open issue
What changed in this PR
Addresses three Claude Code follow-ups: refreshing member descriptions after routing changes, clarifying health-report paths, and aligning coordinator instructions with retired logging behavior.
Changes:
- Adds
squad client sync [--dry-run]and invokes it after Init Mode writes routing. - Adds explicit team-root and squad-directory health fields while preserving compatibility.
- Removes requests for retired logs and updates tests, documentation, and release notes.
| File | Description |
|---|---|
test/clients.test.ts |
Updates the coordinator logging contract assertion. |
test/cli/state-mcp.test.ts |
Checks the new health metadata fields. |
test/claude-members.test.ts |
Covers routing refresh, dry-run, and no-host behavior. |
plugins/squad/skills/squad-coordinator-init-mode/SKILL.md |
Adds post-routing sync to plugin instructions. |
plugins/squad/agents/squad.md |
Removes retired logging requirements. |
packages/squad-sdk/src/tools/index.ts |
Adds explicit paths to MCP health metadata. |
packages/squad-sdk/src/client/adapters/coordinator.ts |
Updates initialization and Scribe instructions. |
packages/squad-cli/src/cli/core/command-help.ts |
Documents sync and its dry-run option. |
packages/squad-cli/src/cli/commands/health.ts |
Adds explicit paths to CLI health metadata. |
packages/squad-cli/src/cli/commands/client.ts |
Implements the sync subcommand. |
packages/squad-cli/src/cli-entry.ts |
Lists sync in top-level help. |
docs/src/content/docs/scenarios/using-squad-across-clients.md |
Explains refreshing configured host files. |
docs/src/content/docs/reference/cli.md |
Clarifies health path fields and compatibility. |
CHANGELOG.md |
Records the three follow-up changes. |
.changeset/claude-polish.md |
Declares SDK and CLI patch releases. |
Review effort: Balanced (auto)
| const squadDir = detectSquadDir(dest).path; | ||
| const synced = await syncClients(dest, squadDir, { dryRun, warn: (m) => console.warn(m) }); |
| } | ||
|
|
||
| console.error(`❌ Unknown client subcommand: ${sub}\n Usage: squad client list [--json] | squad client add <list> [--dry-run]`); | ||
| if (sub === 'sync') { |
…laude-polish # Conflicts: # CHANGELOG.md

Claude Code follow-ups from the end-to-end test (epic #2438, checklist #2469).
Closes #2456
Closes #2455
Closes #2454
Closes #2458
#2456: member descriptions after routing
squad castwrites.claude/agents/<member>.mdstraight away, but Init Mode writesrouting.mdafterwards, so descriptions stayed at "Owns: " untilsquad upgrade. Claude Code uses that description to decide when to delegate.squad client sync [--dry-run]re-projects the hosts already configured in.squad/config.json, rewriting only Squad-managed files. It's a no-op when no host is configured.squad client synconcerouting.mdis written. The plugin's generated copy is rebuilt and still pinned to2.0.0-preview.4.#2455: health directories
resolvedTeamDirholds the team root (the directory that contains.squad), which reads like the squad directory. Renaming it would breaksquad-state-health/v1consumers, so bothsquad_state_healthandsquad health --jsonkeep it as is and add:resolvedTeamRoot: the same value, correctly named.resolvedSquadDir: the squad directory itself.The CLI reference documents all three.
#2454: Scribe and the retired logs
The Claude coordinator digest (item 11) asked Scribe to append session and orchestration logs. Scribe's charter and the Copilot coordinator both retired them, so Scribe refused. The digest now says neither Scribe nor the coordinator writes them, and the behavioural-contract parity test pins the new rule instead of the old
orchestration-log///log/paths.Plugin skill frontmatter and #2458
cli-wiringandretro-enforcementtemplate skills get frontmatter, soclaude plugin validate plugins/squadpasses with no warnings. The edit is in.squad-templates/and its package mirrors;templates/gets only these two files, because its other files have drifted.squad init --client claudealso writing the Copilot files is intended. Copilot is the base host, and.github/agents/squad.agent.mdis the canonical coordinator (ADR-003 proposes otherwise).client-compatibility.mdnow says so, along with how to skip the optional parts.Testing
test/claude-members.test.ts: cast, then writerouting.md, thensquad client sync --dry-run(no change), thensquad client sync(the description gains "Owns: … Payments API"). Also a sync with no host configured, which writes nothing.squad-20bridge scenarios that fail identically on a cleanorigin/dev.npm run lintis clean, and the plugin--checkis current. Markdownlint and cspell are clean for the changed docs.Changeset and
[Unreleased]entries are included; there's no version bump.🤖 Generated with Claude Code