Skip to content

squad upgrade installs Squad's own CI/release workflows that init deliberately skips (regression of #201) #2527

Open

Description

@bradygaster

Version: CLI built from release/prepare-2.0.0-preview.5 @ 38d45d02 (package version 2.0.0-preview.6).

What happens

squad init installs only the four framework workflows (#201). Running squad upgrade right after, with nothing changed in between, adds seven more workflows. These are Squad's own product CI/CD, built for Squad's dev/preview/main/insider branch model.

D=$(mktemp -d); cd "$D"; git init -q
node <squad-cli>/dist/cli-entry.js init --roles --client copilot,claude
ls -1 .github/workflows
#   squad-heartbeat.yml  squad-issue-assign.yml  squad-triage.yml  sync-squad-labels.yml
node <squad-cli>/dist/cli-entry.js upgrade --dry-run | grep workflows
#   create    .github/workflows/squad-ci.yml
#   create    .github/workflows/squad-docs.yml
#   create    .github/workflows/squad-insider-release.yml
#   create    .github/workflows/squad-label-enforce.yml
#   create    .github/workflows/squad-preview.yml
#   create    .github/workflows/squad-promote.yml
#   create    .github/workflows/squad-release.yml

A real squad upgrade creates all seven files. For a non-npm project, the five in PROJECT_TYPE_SENSITIVE_WORKFLOWS become TODO stubs that still trigger on pushes and PRs to dev/preview/main/insider. squad-promote.yml and squad-label-enforce.yml are copied verbatim.

Expected

upgrade installs and refreshes the same workflow set that init installs (FRAMEWORK_WORKFLOWS). It updates any other squad-*.yml only if it's already present, because the user opted in. It never creates one.

Source

  • packages/squad-sdk/src/config/init.ts, line 773: the FRAMEWORK_WORKFLOWS allowlist that init uses (the squad init installs generic CI/CD workflows without opt-in #201 fix).
  • packages/squad-cli/src/cli/core/upgrade.ts, collectSquadOwnedCandidates (line 606). Line 623 onward iterates every *.yml in templates/workflows/ and plans each as a candidate, with no FRAMEWORK_WORKFLOWS filter.
  • packages/squad-cli/src/cli/core/templates.ts, lines ~350–415: TEMPLATE_MANIFEST lists all 11 workflows with overwriteOnUpgrade: true.
  • packages/squad-cli/src/cli/core/workflows.ts, line 8: PROJECT_TYPE_SENSITIVE_WORKFLOWS.

Related: #201 (original init fix), #2047 (upgrade refreshing templates), #2361.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions