Skip to content

squad cast can't add a second member with the same role: the provenance "rename" heuristic matches on the exact role string #2524

Open

Description

@bradygaster

Version: CLI built from release/prepare-2.0.0-preview.5 @ 38d45d02 (package version 2.0.0-preview.6).

What happens

Casting a second member whose role string equals an existing active member's role is rejected:

D=$(mktemp -d); cd "$D"; git init -q
node <squad-cli>/dist/cli-entry.js init --roles --client copilot,claude
node <squad-cli>/dist/cli-entry.js cast --name Alpha --role "Test Engineer"   # ✓
node <squad-cli>/dist/cli-entry.js cast --name Beta  --role "Test Engineer"   # ✗
AgentProvenanceError: New agent id "beta" ambiguously resembles existing role owner(s) alpha; supply the existing stable id for a rename

Teams with two or more people in the same role (two Test Engineers, two Backend Engineers) can't be cast with squad cast. The only workaround is to invent a distinct role string for each member. This failure also leaves partial state behind; that's #2525.

Why it looks wrong

  • The docblock on reconcileAgentProvenanceRegistry says identity binds only through the explicit id: "Display name, role, labels, paths, and other incidental signals never establish identity." The roleHints check makes role establish (suspected) identity anyway.
  • The hint can't be followed from the CLI. squad cast derives the id from --name, and it has no way to "supply the existing stable id for a rename." Renaming Alpha to Beta and adding Beta as a new member look identical, so the heuristic blocks the add.

Expected

Adding a member with a new id and a new display name always adds a member, even when its role matches someone else's. A rename should be explicit, for example squad cast --rename <existing-id> --name <new-name>, or a dedicated squad rename. That would supply the existing id to reconcileAgentProvenanceRegistry. The ambiguity check could be dropped, or turned into an informational note ("Alpha already holds Test Engineer; adding Beta as a second one").

Source

  • packages/squad-sdk/src/casting/agent-provenance.ts, lines 1194–1203 (if (!previous) { const roleHints = ... record.role === role ...; throw ... }). The docblock contradicting it is at lines 1142–1148.
  • packages/squad-cli/src/cli/commands/cast.ts: updateCastingStateWithAgent (line 295) passes one candidate { id: slug, displayName, role, universe: 'cli-cast' } and has no rename input.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions