Skip to content

fix(extensions): omit config hint when no scaffolding fails - #5459

Open
dlwlgnsrhy wants to merge 1 commit into
github:mainfrom
dlwlgnsrhy:fix/extension-config-warning
Open

dlwlgnsrhy wants to merge 1 commit into
github:mainfrom
dlwlgnsrhy:fix/extension-config-warning

Conversation

@dlwlgnsrhy

Copy link
Copy Markdown
Contributor

Description

specify extension add --dev prints a configuration warning for the bundled bug extension even though its manifest declares no config. The same thing happens when provides.config is empty. Show the configuration hint only when scaffolding reports a failure. Failed templates still produce both the specific warning and the generic configuration hint.

Testing

  • Ran .venv/bin/specify --help.
  • Ran the affected tests with LC_ALL=en_US.UTF-8 .venv/bin/python -m pytest --override-ini addopts='' tests/specify_cli/extensions tests/test_extensions.py -q. 752 passed.
  • Tested specify extension add in four temporary projects. No warning for the bundled bug extension, config generated from a template, existing config preserved byte-for-byte, and both warnings retained for a missing declared template.

The new parametrized regression test reported 2 failures and 1 pass against upstream e210504a. The no-config and empty-config cases failed on the unexpected hint. All three cases pass with the fix. The existing Rich escaping test now simulates a scaffolding failure so it still exercises the hint.

AI Disclosure

  • I did use AI assistance.

AI disclosure: OpenAI Codex (GPT-6, reasoning effort unavailable, autonomous under contributor direction) reproduced the issue, implemented the patch and regression tests, ran the automated and temporary-project checks, and authored the commit and PR on behalf of @dlwlgnsrhy. These checks were agent-executed.

Show the generic configuration hint only alongside an actual scaffolding failure. Cover undeclared, empty, and missing-template configurations through the CLI.

Assisted-by: OpenAI Codex (model: GPT-6, autonomous)
@dlwlgnsrhy
dlwlgnsrhy requested a review from mnriem as a code owner November 17, 2026 08:25
Copilot AI adaptive review requested due to automatic review settings November 17, 2026 08:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed changes address the misleading configuration hint and add regression coverage for the relevant scaffolding paths, with no active review issues identified.

No open issues 🎉

What changed in this PR

This pull request updates specify extension add so the generic configuration hint is shown only when configuration scaffolding fails, avoiding misleading warnings for extensions without declared configuration.

Changes:

  • Added regression coverage for undeclared, empty, and failed configuration scaffolding.
  • Restricted the generic configuration hint to the scaffolding-failure path.
  • Updated the Rich escaping test to simulate scaffolding failure while preserving its coverage.
File Description
tests/​specify_cli/​extensions/​test_command_add.py Adds regression coverage for configuration-warning behavior and updates the escaping test to exercise a scaffolding failure.
src/​specify_cli/​extensions/​command_add.py Emits the generic configuration hint only when configuration scaffolding reports failures.

Review effort: Lite (adaptive)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants