You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(presets): reconcile command files after priority changes - #5113
When a preset priority changes, the resolver can select a different command layer while the generated agent command file still contains the previous winner. Reconcile the affected command and skill artifacts against the full priority stack after updating the registry.
The regression fails against main at 67e0f72 and passes with this change.
Preset tests: 744 passed, 1 skipped.
Ruff check and format checks pass for both changed files.
The regression invokes specify preset set-priority in a temporary Gemini project and verifies the generated command switches to the new winner.
AI Disclosure
I did use AI assistance (fill in the disclosure below)
AI disclosure: OpenAI Codex (GPT-6; reasoning effort not exposed in this task; autonomous); issue analysis, reproduction, code and regression-test generation, and validation.
Review follow-up by @mikamikasuki with OpenAI Codex (GPT-6, autonomous). AI authored the review analysis, implementation, regression tests, and this summary.
Updated priority reconciliation to include convention-based command files and to leave artifacts untouched when the target preset is disabled. Added coverage for skills-mode rematerialization and for command reconciliation failures while preserving the saved priority and constitution reconciliation.
Validation: test_command_set_priority.py — 11 passed; git diff --check passed. Ruff was unavailable in the local environment.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Priority reconciliation can leave stale skills and orphaned command files, and can incorrectly expose manifest-declared wrappers as standalone commands.
A convention-only override of an existing core skill is filtered out before this new rendering path: no preset has recorded its name in registered_skills, so dir_cmds is empty. In an initialized Claude project, changing the priority of an undeclared commands/speckit.specify.md therefore leaves the core skill unchanged. Admit existing skills in the active directory before this filter, while keeping historical directories restricted to tracked names, and cover the case without a manifest-declared competitor.
AI-generated review for the review requester by GitHub Copilot (model: unknown; autonomous); analysis and comment generation.
Track convention-based commands through install, priority changes, and removal, refresh active core skills safely, and guard composed cache writes against symlinks. Add regressions for reinstall, fallback restoration, core skill overrides, and cache traversal.
Assisted-by: OpenAI Codex (model: GPT-6, autonomous)
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a preset priority changes, the resolver can select a different command layer while the generated agent command file still contains the previous winner. Reconcile the affected command and skill artifacts against the full priority stack after updating the registry.
Closes #5087
Testing
specify preset set-priorityin a temporary Gemini project and verifies the generated command switches to the new winner.AI Disclosure
AI disclosure: OpenAI Codex (GPT-6; reasoning effort not exposed in this task; autonomous); issue analysis, reproduction, code and regression-test generation, and validation.