[WOLIKIMCHENG]

Description

Load project-installed custom workflow steps before workflow update validates downloaded candidates. This aligns update with add, run, and resume while using the active project's custom-step registry.

The update path now refreshes project-local custom steps between projects, so a type from one project is not accepted when updating another. Invalid updates continue to leave the installed workflow and registry unchanged.

Testing

• tests/specify_cli/workflows/test_command_update.py and test_custom_steps.py: 24 passed
• tests/specify_cli/workflows: 588 passed, 1 skipped
• tests/test_workflows.py: 779 passed
• git diff --check origin/main

[Copilot]

Copilot review overview

🟡 Changes recommended

Process-global custom steps can leak across projects and incorrectly validate an update.

Review effort: Balanced
Findings: 1

Open (1)

• Global step registry leaks custom steps across projects · New

What changed in this PR

Loads custom workflow steps before validating workflow updates.

Changes:

• Registers project custom steps during workflow update.
• Adds success and transactional rejection regressions.

File	Description
src/​specify_cli/​workflows/​command_update.py	Loads custom steps before update validation.
tests/​specify_cli/​workflows/​test_command_update.py	Tests custom and unknown step updates.

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[WOLIKIMCHENG]

Addressed on the current head. workflow update calls load_custom_steps(project_root) before validating the downloaded workflow. load_custom_steps() clears non-built-in registry entries and tracked synthetic imports before loading the active project's steps. This prevents a type installed only in project A from validating project B, while allowing B's implementation to replace A's when both use the same key.

Coverage proves these at two boundaries: test_update_refreshes_custom_steps_between_projects directly exercises consecutive A-to-B CLI updates and verifies that B rejects A's type without changing B's installed workflow file or persistent WorkflowRegistry metadata. Separately, test_custom_steps_refresh_for_active_project loads distinct A and B implementations under the same key and verifies that B's implementation is active after the switch. The focused workflow modules passed: 24 passed. No additional code change is needed for this finding.

[mnriem]

Please address Copilot feedback

[Copilot]

🟢 Approval recommended

The focused fix is consistent with existing workflow commands and has comprehensive regression coverage.

1 open finding

• Global step registry leaks custom steps across projects

🧠 Review effort: Balanced

---

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

[mnriem]

Please address Copilot feedback

[WOLIKIMCHENG]

@mnriem Thank you for the follow-up. I've addressed the Copilot feedback by refreshing project-local custom steps before workflow update validation and adding a same-process A-to-B regression. The focused tests passed (24 tests).

I noticed that #4470 also includes broader project-scoped registry isolation. When convenient, could you advise whether you'd prefer to keep #4768 as a narrow update-path fix or consolidate it with #4470? I'm happy to follow your guidance.

[Copilot]

🟢 Approval recommended

The focused implementation is consistent with existing commands and has strong positive and negative regression coverage.

1 open finding

• Global step registry leaks custom steps across projects

🧠 Review effort: Balanced

[mnriem]

Please address Copilot feedback. If not applicable please explain why

[WOLIKIMCHENG]

@mnriem Thanks for the follow-up. I’ve replied directly to the Copilot review thread with the current behavior and regression-test evidence: #4768 (comment).

[Copilot]

🟢 Approval recommended

The focused change reuses existing registry-refresh behavior and includes positive and negative regression coverage, with no unresolved findings.

1 open finding

• Global step registry leaks custom steps across projects

🧠 Review effort: Balanced

[mnriem]

Thank you!