Repository navigation
chore: refactor self command domain - #4685
Merged
Merged
Conversation
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
No unresolved issues were identified, and compatibility is covered by the updated tests.
Review effort: Balanced
Findings: None
What changed in this PR
Refactors the specify self command hierarchy into specify_cli.selfs while preserving _version compatibility.
Changes:
- Added dedicated check and upgrade command adapters.
- Reorganized command tests and shared helpers.
- Documented the plural package convention.
| File | Change |
|---|---|
tests/鈥媠pecify_cli/鈥媡est_version_verification.py |
Updates verification coverage and imports. |
tests/鈥媠pecify_cli/鈥媡est_version_release.py |
Retains version release coverage. |
tests/鈥媠pecify_cli/鈥媡est_version_imports.py |
Verifies compatibility exports. |
tests/鈥媠pecify_cli/鈥媡est_version_guidance.py |
Updates shared helper imports. |
tests/鈥媠pecify_cli/鈥媡est_version_execution.py |
Updates shared helper imports. |
tests/鈥媠pecify_cli/鈥媡est_version_detection.py |
Updates shared helper imports. |
tests/鈥媠pecify_cli/鈥媠elfs/鈥媡est_command_upgrade.py |
Covers the relocated upgrade command. |
tests/鈥媠pecify_cli/鈥媠elfs/鈥媡est_command_check.py |
Covers the relocated check command. |
tests/鈥媠pecify_cli/鈥媠elfs/鈥媉_init__.py |
Initializes the self-command test package. |
tests/鈥媠pecify_cli/鈥媠elf_upgrade_helpers.py |
Provides shared upgrade-test helpers. |
src/鈥媠pecify_cli/鈥媠elfs/鈥媍ommand_upgrade.py |
Implements the upgrade adapter. |
src/鈥媠pecify_cli/鈥媠elfs/鈥媍ommand_check.py |
Implements the check adapter. |
src/鈥媠pecify_cli/鈥媠elfs/鈥媉_init__.py |
Defines and registers the self command group. |
src/鈥媠pecify_cli/鈥媉version.py |
Preserves version logic and compatibility exports. |
src/鈥媠pecify_cli/鈥媉_init__.py |
Registers the refactored command group. |
design/鈥媍li.md |
Documents command-group package naming. |
馃挕 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specify selfcommand hierarchy intospecify_cli.selfswith dedicatedcommand_check.pyandcommand_upgrade.pyadaptersspecify_cli._versionas the established domain and monkeypatch compatibility surfacetests/specify_cli/selfswhile retaining version-domain tests at the package levelValidation
uvx ruff@0.15.0 check src testsgit diff --checkAuthored by GitHub Copilot (model: GPT-5.6 Sol, autonomous) on behalf of @mnriem; implementation and this PR description are AI-generated.