Repository navigation
chore: refactor event domain layout - #4683
Merged
Merged
Conversation
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Behavior and test coverage are preserved; only a non-blocking module-docstring convention remains.
Review effort: Balanced
Findings: None
What changed in this PR
Refactors events into a domain package while preserving the existing API and CLI behavior.
Changes:
- Moves
event runintoevents/command_run.py. - Updates registration and relative imports.
- Mirrors event tests under the new package layout.
| File | Description |
|---|---|
src/specify_cli/__init__.py |
Registers commands through the events package. |
src/specify_cli/events/__init__.py |
Hosts event domain APIs and command-group registration. |
src/specify_cli/events/command_run.py |
Hosts the event run adapter. |
tests/specify_cli/events/__init__.py |
Defines the mirrored test package. |
tests/specify_cli/events/test_command_run.py |
Updates command imports and monkeypatch paths. |
tests/specify_cli/events/test_events.py |
Updates event-domain test terminology. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specify_cli.eventsfrom a module into the event domain package while preserving its established import and monkeypatch surfacespecify event runadapter toevents/command_run.pyand register the nested command from the packagetests/specify_cli/events/and remove the obsoletecommands/event.pylayoutValidation
python -m pytest— 8,394 passed, 16 skippeduvx ruff@0.15.0 check src testsgit diff --checkAuthored and opened on behalf of @mnriem by GitHub Copilot (model: GPT-5.6 Sol, autonomous); the code changes and PR description were fully AI-generated.