Skip to content

chore: refactor event domain layout - #4683

Merged
mnriem merged 1 commit into
github:mainfrom
mnriem:mnriem-chore/event-domain-refactor
Sep 22, 2026
Merged

mnriem merged 1 commit into
github:mainfrom
mnriem:mnriem-chore/event-domain-refactor

Conversation

@mnriem

@mnriem mnriem commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • convert specify_cli.events from a module into the event domain package while preserving its established import and monkeypatch surface
  • move the specify event run adapter to events/command_run.py and register the nested command from the package
  • mirror command and domain tests under tests/specify_cli/events/ and remove the obsolete commands/event.py layout

Validation

  • python -m pytest — 8,394 passed, 16 skipped
  • uvx ruff@0.15.0 check src tests
  • git diff --check
  • wheel content verification confirmed the new package modules are included and obsolete modules are absent

Authored and opened on behalf of @mnriem by GitHub Copilot (model: GPT-5.6 Sol, autonomous); the code changes and PR description were fully AI-generated.

Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 22, 2026 17:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Behavior and test coverage are preserved; only a non-blocking module-docstring convention remains.

Review effort: Balanced
Findings: None

What changed in this PR

Refactors events into a domain package while preserving the existing API and CLI behavior.

Changes:

  • Moves event run into events/command_run.py.
  • Updates registration and relative imports.
  • Mirrors event tests under the new package layout.
File Description
src/​specify_cli/​__init__.py Registers commands through the events package.
src/​specify_cli/​events/​__init__.py Hosts event domain APIs and command-group registration.
src/​specify_cli/​events/​command_run.py Hosts the event run adapter.
tests/​specify_cli/​events/​__init__.py Defines the mirrored test package.
tests/​specify_cli/​events/​test_command_run.py Updates command imports and monkeypatch paths.
tests/​specify_cli/​events/​test_events.py Updates event-domain test terminology.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mnriem mnriem added the triage-out-of-scope Verdict: won't land in core — invalid, duplicate, off-mission, or redirected to an extension label Sep 22, 2026
@mnriem
mnriem merged commit 6a8870f into github:main Sep 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage-out-of-scope Verdict: won't land in core — invalid, duplicate, off-mission, or redirected to an extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants