fix: narrow exception in script permission check from Exception to OSError/PermissionError - #3916
Open
Quratulain-bilal wants to merge 2 commits into
Open
Quratulain-bilal wants to merge 2 commits into
Quratulain-bilal wants to merge 2 commits into
Conversation
…Error/PermissionError Bare 'except Exception' silently swallows all errors. Narrow to (OSError, PermissionError) which are the realistic failure modes for file open/read operations.
Contributor
There was a problem hiding this comment.
Pull request overview
Narrows exception handling during script shebang checks.
Changes:
- Replaces broad
Exceptionhandling with filesystem-specific exceptions.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/__init__.py |
Narrows script-read exception handling. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
| if f.read(2) != b"#!": | ||
| continue | ||
| except Exception: | ||
| except (OSError, PermissionError): |
…Error/PermissionError Narrow except Exception to (OSError, PermissionError) which are the realistic failure modes for file open/read operations during shebang checks. Add regression tests verifying: - OSError during open() is skipped (not propagated) - Unexpected RuntimeError propagates to outer failure handler - Normal shebang scripts get executable bits (POSIX only) - Scripts without shebang are skipped (POSIX only) Co-authored-by: GitHub Copilot (model: mimo-v2.5-free, supervised)
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
tests/test_ensure_executable_scripts.py:71
- This assertion does not distinguish the new code from the previous
except Exception: in both versions no exception escapes and the script remains non-executable. Assert that the unexpected exception reaches the outer handler's failure-reporting path; using the already importedMagicMockalso avoids the current Ruff F401 failure.
with patch.object(Path, "open", open_side_effect):
# RuntimeError is NOT in (OSError, PermissionError), so the inner
# except does NOT catch it. The outer except Exception handler
# catches it and appends to failures[]. No exception escapes.
ensure_executable_scripts(tmp_path)
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| from specify_cli import ensure_executable_scripts | ||
|
|
||
|
|
||
| class TestEnsureExecutableScriptsExceptionNarrowing: |
mnriem
requested changes
Sep 14, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bare
except Exceptionsilently swallows all errors during script permission checks.Fix
Narrow to
(OSError, PermissionError)which are the realistic failure modes for file open/read operations.Testing