fix: bound response read in bundler catalog fetcher - #3779
Closed
Quratulain-bilal wants to merge 0 commit into
Closed
Quratulain-bilal wants to merge 0 commit into
Quratulain-bilal wants to merge 0 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Bounds remote catalog response reads to mitigate memory-exhaustion attacks.
Changes:
- Uses the shared 1 MiB JSON metadata limit.
- Replaces unbounded response reading with
read_response_limited().
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/bundler/services/adapters.py |
Adds bounded catalog response reading. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
Quratulain-bilal
added a commit
to Quratulain-bilal/spec-kit
that referenced
this pull request
Jul 28, 2026
…dapter - Update test_http_fetch_rejects_oversized_response to use correct constant - Verify _http_get_json uses MAX_JSON_CATALOG_BYTES via read_response_limited Fixes github#3779
Quratulain-bilal
force-pushed
the
fix/unbounded-bundler-adapter-read
branch
from
July 28, 2026 23:18
a247681 to
be33d2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace unbounded
esponse.read()\ with
ead_response_limited()\ in \�undler/services/adapters.py\ to prevent DoS via oversized catalog responses.
Changes
aw = response.read().decode("utf-8")\ with
aw = read_response_limited(response, max_bytes=MAX_JSON_METADATA_BYTES).decode("utf-8")\ at line 183