fix: align Implementation.Name with VS Code config key#2577
Open
SamMorrowDrums wants to merge 1 commit into
Open
fix: align Implementation.Name with VS Code config key#2577SamMorrowDrums wants to merge 1 commit into
SamMorrowDrums wants to merge 1 commit into
Conversation
Set the protocol-level Implementation.Name to "github" so the slug matches the configuration key VS Code derives from server.json's title. This fixes "Unknown tool 'github/github-mcp-server/*'" when references use the recommended "github/*" pattern. The MCP registry name in server.json (io.github.github/github-mcp-server) intentionally still uses the source-repo's last segment per the registry naming convention; only the client-facing Implementation.Name changes here. Fixes #1402 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the MCP Implementation.Name default with the configuration key VS Code derives from server.json's title ("github"), so tool prefixes like github/* resolve instead of producing Unknown tool 'github/github-mcp-server/*'. The registry identifier in server.json intentionally remains distinct, per the MCP registry naming convention; a doc comment on NewServer records this divergence.
Changes:
- Change default
SERVER_NAMEtranslation default from"github-mcp-server"to"github"inNewMCPServer. - Update the empty-string fallback in
NewServerand its doc comment to match, including a note explaining the divergence from the registry name. - Update
TestNewServer_NameAndTitleViaTranslationdefaults expectation accordingly.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/server.go | Changes default server name to "github" and updates NewServer doc comment |
| pkg/github/server_test.go | Updates test default-name expectation and translator default |
Note: README.md (around line 1569) still documents the SERVER_NAME default as github-mcp-server and should be updated to reflect the new default, but that file is not part of this diff.
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the protocol-level
Implementation.Nameto"github"so the slug matches the configuration key VS Code derives fromserver.json's title. Without this, references using the recommendedgithub/*tool prefix surface asUnknown tool 'github/github-mcp-server/*'.The MCP registry name in
server.json(io.github.github/github-mcp-server) intentionally still uses the source-repo's last segment per the registry naming convention — only the client-facingImplementation.Namechanges here. A comment onNewServerdocuments the divergence so future contributors don't try to "re-sync" them.Replaces #2043 (force-pushed branch, original commit lost). Co-authored to @yashhzd.
Fixes #1402
Verification
script/lint— cleango test ./pkg/github -run TestNewServer_NameAndTitleViaTranslation -count=1— passes (test expectations updated)script/test— passes