Add regression coverage for update_issue MCP body length handling above 10KB#46781
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
👋 Thanks for the fix! This PR looks great — it's a focused test-addition that adds solid regression coverage for the What this does well:
Ready for review — the tests look comprehensive and the implementation follows the test structure in place. 🎉 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "patchdiff.githubusercontent.com"See Network Configuration for more information.
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
update_issue MCP body length handling above 10KB
There was a problem hiding this comment.
Pull request overview
Adds regression coverage ensuring update_issue.body honors its explicit schema length limit instead of the default 10KB MCP guard.
Changes:
- Loads the real
update_issuetool schema with actionable failures. - Tests acceptance above 10KB and rejection above 65,536 characters.
Show a summary per file
| File | Description |
|---|---|
actions/setup/js/mcp_scripts_validation.test.cjs |
Adds schema-backed body-length regression tests. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
|
🎉 This pull request is included in a new release. Release: |
update_issuewas previously vulnerable to an MCP pre-validation mismatch where large bodies could be rejected by the default 10KB string guard instead of honoring the tool schema’s explicit body limit. This PR adds focused regression tests soupdate_issue.bodybehavior stays aligned with the 65KB-class schema contract used by sibling issue/comment tools.Regression scope: MCP string-length pre-validation vs tool schema
actions/setup/js/mcp_scripts_validation.test.cjsforupdate_issueusing the realsafe_outputs_tools.jsonschema.bodylarger thanMAX_STRING_INPUT_BYTESis accepted whenupdate_issue.body.maxLengthis declared.65537) are still rejected with abodymax-length violation.Fixture/schema loading hardening
update_issueschema fromsafe_outputs_tools.json.