Skip to content

fix(daily-doc-updater): handle new-file creation requests in Step 1b #24742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 5, 2026
+11 −1
Merged

fix(daily-doc-updater): handle new-file creation requests in Step 1b #24742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27dac27
Initial plan
Copilot Apr 5, 2026
9fc365c
fix(daily-doc-updater): explicitly handle new-file creation requests …
Copilot Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/daily-doc-updater.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,11 @@ repo:${{ github.repository }} is:issue is:open label:documentation
For each open issue:
1. Read the issue body to understand the described gap.
2. Check the referenced documentation file to verify the gap still exists.
- **If the issue references an existing file**: confirm the content is missing or incorrect.
- **If the issue references a file path that does not yet exist** (e.g., body says "Create `docs/guides/foo.md`"): treat this as a **confirmed new-file gap** and proceed to Step 5 to create the file.
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example new-file path docs/guides/foo.md doesn’t exist in this repo (docs live under docs/src/content/docs/...). Using a non-existent path in the instructions could mislead the agent into creating files in the wrong location; update the example (and wording, if needed) to reference the actual docs tree used here.

Suggested change
- **If the issue references a file path that does not yet exist** (e.g., body says "Create `docs/guides/foo.md`"): treat this as a **confirmed new-file gap** and proceed to Step 5 to create the file.
- **If the issue references a file path that does not yet exist** (e.g., body says "Create `docs/src/content/docs/guides/foo.md`"): treat this as a **confirmed new-file gap** and proceed to Step 5 to create the file.

Copilot uses AI. Check for mistakes.
3. If confirmed, include a fix in this run's PR and reference the issue with `Closes #NNN`.
4. If the gap is already fixed, note it (do not reopen or comment on the issue).
4. If the gap is already fixed (file exists and contains the described content), note it and skip.
5. If you choose not to address an open documentation issue in this run (e.g., it requires structural navigation changes, is out of scope, or cannot be confirmed), record it in the **Skipped Issues** section of the PR description (see Step 6).
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 1b now mandates recording skipped open documentation issues in the PR description, but Step 6 only applies when a PR is created (i.e., when docs changes were made). If a run makes no doc changes and calls noop, skipped issues could still be silently dropped; clarify where to record skipped issues in the no-PR/noop case (or require creating a PR when any issues are skipped).

Suggested change
5. If you choose not to address an open documentation issue in this run (e.g., it requires structural navigation changes, is out of scope, or cannot be confirmed), record it in the **Skipped Issues** section of the PR description (see Step 6).
5. If you choose not to address an open documentation issue in this run (e.g., it requires structural navigation changes, is out of scope, or cannot be confirmed), you must still record it. If this run creates a PR, record it in the **Skipped Issues** section of the PR description (see Step 6). If this run makes no documentation changes and would otherwise `noop`, include the skipped issues and the reason each was skipped in the `noop` message or final run summary so they are still reported even without a PR.

Copilot uses AI. Check for mistakes.

### 1c. Scan Recently Closed Documentation Issues

Expand Down Expand Up @@ -250,6 +253,13 @@ This PR updates the documentation based on features merged in the last 24 hours.

</details>

### Skipped Issues

<!-- List every open documentation issue that was NOT addressed in this run -->
<!-- Format: - #NNN — [title]: [reason for skip] -->
<!-- Example: - #123 — docs: add guide for foo: requires structural nav changes beyond docs scope -->
<!-- If all open issues were addressed or confirmed already fixed, write "None." -->

### Notes

[Any additional notes or features that need manual review]
Expand Down
Loading