[GHSA-hx9m-jf43-8ffr] seroval affected by Denial of Service via RegExp serialization

[Wenxin-Jiang]

Updates

• Affected products

Comments
seroval@0.1.0 exports only serialize() and does not include any deserialization code path. The vulnerable deserialize() function—whose implementation passes attacker-controlled input to indirect evaluation via (0, eval)(source) (see src/index.ts:90)—is first introduced in 0.2.0.

Because 0.1.0 contains no eval-backed deserializer, it provides no sink through which a malicious payload can be executed.

Accordingly, the correct introduced version is 0.2.0, which is the first release that actually contains the vulnerable sink. This aligns the affected range with the first version in which the bug is reachable.

[github]

Hi there @lxsmnsyc! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

[lxsmnsyc]

Seems fine to me. I made the affected range loose in an intent to mark the 0.x versions as deprecated.

[github-actions]

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the Keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot. Please see CONTRIBUTING.md for more policy details.

[shelbyc]

Hi @Wenxin-Jiang, but GHSA-hx9m-jf43-8ffr has been updated to include 0.2.0 as the lowest vulnerable version, but a bug is stopping the PR from merging, so I have to close the PR rather than the PR merging automatically. Thanks for your interest in GHSA-hx9m-jf43-8ffr!