[GHSA-78xj-cgh5-2h22] NPM IP package incorrectly identifies some private IP addresses as public#3617
Closed
ouuan wants to merge 1 commit intoouuan/advisory-improvement-3617from
Closed
[GHSA-78xj-cgh5-2h22] NPM IP package incorrectly identifies some private IP addresses as public#3617ouuan wants to merge 1 commit intoouuan/advisory-improvement-3617from
ouuan wants to merge 1 commit intoouuan/advisory-improvement-3617from
Conversation
github-actions
bot
changed the base branch from
main
to
ouuan/advisory-improvement-3617
|
Hi @ouuan, incomplete fixes normally receive separate CVE IDs. A CVE ID can be obtained from GitHub through the repository's security advisory feature. |
Author
|
Fine. I also think a new CVE is better, but the maintainer is very inactive so I tried to edit the old CVE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
The patch indutny/node-ip#138 does not cover all cases. See indutny/node-ip#143