refactor(storage): compose runner config storage providers - #5359
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 4, 2026 11:20
6af275a to
456b25c
Compare
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 4, 2026 11:34
456b25c to
93e7105
Compare
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 4, 2026 11:42
93e7105 to
de85c37
Compare
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 4, 2026 11:49
de85c37 to
48f1d66
Compare
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 4, 2026 12:10
e8f7a26 to
9e5205f
Compare
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 4, 2026 12:23
9e5205f to
0850256
Compare
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 4, 2026 12:27
0850256 to
909dc67
Compare
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
4 times, most recently
from
September 4, 2026 12:54
ff1925b to
5149453
Compare
edersonbrilhante
added
compute-provider:aws_microvm
javascript
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
2 times, most recently
from
September 7, 2026 12:49
cf64d4e to
d42c5d3
Compare
edersonbrilhante
marked this pull request as ready for review
September 7, 2026 13:54
guicaulada
reviewed
Sep 8, 2026
guicaulada
left a comment
guicaulada
left a comment
Contributor
There was a problem hiding this comment.
LGTM! One minor comment about caching GitHub credentials... not sure if not caching them is intentional here, or if they are being cached elsewhere.
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 8, 2026 14:29
17f6a3e to
9e197cb
Compare
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 8, 2026 17:29
9e197cb to
47235df
Compare
guicaulada
previously approved these changes
Sep 8, 2026
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 8, 2026 19:42
47235df to
3f6de52
Compare
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 8, 2026 19:46
3f6de52 to
0ac3eee
Compare
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 8, 2026 19:48
0ac3eee to
60996bb
Compare
Co-authored-by: Guilherme Caulada <guilherme.caulada@gmail.com>
edersonbrilhante
force-pushed
the
runner-config-storage-selection
branch
from
September 8, 2026 19:54
60996bb to
d1988d4
Compare
guicaulada
approved these changes
Sep 8, 2026
edersonbrilhante
added a commit
that referenced
this pull request
Sep 8, 2026
## Description Adds structured diagnostics at the asynchronous AWS SSM storage adapter boundaries. A shared logger factory attaches the canonical `aws_ssm` provider identity while each adapter keeps its own module name. Runner-config read and delete failures now preserve their original causes, retryable polling misses remain debug-level events, and terminal failures include bounded error-name chains. Credential values, private keys, Base64 contents, and stored runner configuration values are intentionally excluded from logs. Direct SSM consumer tests now pass only the SSM-specific configuration instead of the generic provider-selection field. This PR is stacked on #5359. ## Test Plan - Ran the storage-provider test suite: 9 files and 74 tests passed. - Ran the storage-provider TypeScript type-check. - Ran ESLint for `lambdas/libs/storage-providers`. - Ran Prettier check for storage-provider TypeScript files. - Ran `git diff --check` and a focused sensitive-log-field scan. ## Related Issues - Related storage-backend work: #5266
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compose the stable storage capabilities in one factory and add runner-config provider selection. Runner-config storage is selected independently from common GitHub App credentials, environment values are parsed once into immutable adapter configuration, and the old parallel provider factories are removed. The storage-provider package now declares its MIT license metadata.
Test Plan
git diff --checkpassed.Related Issues