feat: add support to use custom scale errors - #4932
Merged
npalm merged 11 commits intoJan 6, 2026
Merged
Conversation
edersonbrilhante
marked this pull request as ready for review
December 4, 2025 13:55
edersonbrilhante
force-pushed
the
feat-custom-scale-error
branch
2 times, most recently
from
December 4, 2025 14:04
c3b568d to
68f1f4b
Compare
Member
|
@edersonbrilhante due to the update to the new 7.x release some breaking changes. Please can you rebase the PR? Thanks! |
edersonbrilhante
force-pushed
the
feat-custom-scale-error
branch
from
December 15, 2025 11:11
1885108 to
ee49d34
Compare
edersonbrilhante
force-pushed
the
feat-custom-scale-error
branch
from
December 15, 2025 19:28
7e1cca7 to
6002c6f
Compare
Contributor
Author
|
@npalm I tested and it is working fine :) I added The logs(I redacted the valid ids) show it will was sent back to queue because accepted this error: |
npalm
reviewed
Dec 18, 2025
npalm
previously approved these changes
Dec 18, 2025
npalm
left a comment
Member
There was a problem hiding this comment.
@edersonbrilhante @guicaulada looks good to me. Left a commetn. But this approach is fine as well.
edersonbrilhante
force-pushed
the
feat-custom-scale-error
branch
from
December 18, 2025 22:12
2098ebb to
a50f0d5
Compare
This was referenced Dec 20, 2025
Brend-Smits
approved these changes
Jan 5, 2026
npalm
approved these changes
Jan 6, 2026
npalm
left a comment
Member
There was a problem hiding this comment.
@edersonbrilhante thx for all the hard work, looks to to me
npalm
pushed a commit
that referenced
this pull request
Jan 6, 2026
🤖 I have created a release *beep* *boop* --- ## [7.2.0](v7.1.0...v7.2.0) (2026-01-06) ### Features * add support to use custom scale errors ([#4932](#4932)) ([5285cdc](5285cdc)) @ edersonbrilhante ### Bug Fixes * **lambda:** bump qs from 6.14.0 to 6.14.1 in /lambdas ([#4978](#4978)) ([e27ee7c](e27ee7c)) * **lambda:** bump the aws group in /lambdas with 7 updates ([#4971](#4971)) ([9843662](9843662)) * **lambda:** bump the aws-powertools group in /lambdas with 4 updates ([#4972](#4972)) ([e018a10](e018a10)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
## Summary This PR makes the list of EC2 scaling error codes configurable instead of hardcoded in the control-plane Lambda. It allows users to extend or override the default retryable error set without forcing a change on everyone. ## Motivation Issue [github-aws-runners#4105] was closed without a PR, leaving the scale error list hardcoded. Different environments can encounter additional EC2 error codes that should trigger retries; making this list configurable lets users adapt behavior without modifying the library code. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
🤖 I have created a release *beep* *boop* --- ## [7.2.0](github-aws-runners/terraform-aws-github-runner@v7.1.0...v7.2.0) (2026-01-06) ### Features * add support to use custom scale errors ([github-aws-runners#4932](github-aws-runners#4932)) ([5285cdc](github-aws-runners@5285cdc)) @ edersonbrilhante ### Bug Fixes * **lambda:** bump qs from 6.14.0 to 6.14.1 in /lambdas ([github-aws-runners#4978](github-aws-runners#4978)) ([e27ee7c](github-aws-runners@e27ee7c)) * **lambda:** bump the aws group in /lambdas with 7 updates ([github-aws-runners#4971](github-aws-runners#4971)) ([9843662](github-aws-runners@9843662)) * **lambda:** bump the aws-powertools group in /lambdas with 4 updates ([github-aws-runners#4972](github-aws-runners#4972)) ([e018a10](github-aws-runners@e018a10)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
zeekay
pushed a commit
to zeekay/terraform-aws-github-runner
that referenced
this pull request
Sep 9, 2026
## Summary This PR makes the list of EC2 scaling error codes configurable instead of hardcoded in the control-plane Lambda. It allows users to extend or override the default retryable error set without forcing a change on everyone. ## Motivation Issue [github-aws-runners#4105] was closed without a PR, leaving the scale error list hardcoded. Different environments can encounter additional EC2 error codes that should trigger retries; making this list configurable lets users adapt behavior without modifying the library code. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zeekay
pushed a commit
to zeekay/terraform-aws-github-runner
that referenced
this pull request
Sep 9, 2026
🤖 I have created a release *beep* *boop* --- ## [7.2.0](github-aws-runners/terraform-aws-github-runner@v7.1.0...v7.2.0) (2026-01-06) ### Features * add support to use custom scale errors ([github-aws-runners#4932](github-aws-runners#4932)) ([bede2ff](github-aws-runners@bede2ff)) @ edersonbrilhante ### Bug Fixes * **lambda:** bump qs from 6.14.0 to 6.14.1 in /lambdas ([github-aws-runners#4978](github-aws-runners#4978)) ([d587d42](github-aws-runners@d587d42)) * **lambda:** bump the aws group in /lambdas with 7 updates ([github-aws-runners#4971](github-aws-runners#4971)) ([65d303e](github-aws-runners@65d303e)) * **lambda:** bump the aws-powertools group in /lambdas with 4 updates ([github-aws-runners#4972](github-aws-runners#4972)) ([91f044d](github-aws-runners@91f044d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the list of EC2 scaling error codes configurable instead of hardcoded in the control-plane Lambda. It allows users to extend or override the default retryable error set without forcing a change on everyone.
Motivation
Issue [#4105] was closed without a PR, leaving the scale error list hardcoded.
Different environments can encounter additional EC2 error codes that should trigger retries; making this list configurable lets users adapt behavior without modifying the library code.