We have been noticing that some of the EC2 instances, the control plane spawns, are getting to the ghr:created_by tag set to random values of "scale-up-lambda" and "pool-lambda" even though they are being created by only the "scale-up-lambda" as a pool does not exist for the runner type we have noticed the behaviour in.
Looking at the code,
|
{ Key: 'ghr:created_by', Value: runnerParameters.numberOfRunners === 1 ? 'scale-up-lambda' : 'pool-lambda' }, |
Looks like the issue is that the default is set to "pool-lambda": currently, if x.numberofrunners is 1, it's the "scale-up" lambda; otherwise, it sets the default to "pool-lambda". Since
https://github.com/github-aws-runners/terraform-aws-github-runner/releases/tag/v7.0.0, we now process in batches, which means we are almost always doing actions in multiple rather than single (scale-up) and multiple (pool).
We really need to allign this with the https://github.com/github-aws-runners/terraform-aws-github-runner/releases/tag/v7.0.0 change
We have been noticing that some of the EC2 instances, the control plane spawns, are getting to the ghr:created_by tag set to random values of "scale-up-lambda" and "pool-lambda" even though they are being created by only the "scale-up-lambda" as a pool does not exist for the runner type we have noticed the behaviour in.
Looking at the code,
terraform-aws-github-runner/lambdas/functions/control-plane/src/aws/runners.ts
Line 244 in 6dc97d5
Looks like the issue is that the default is set to "pool-lambda": currently, if x.numberofrunners is 1, it's the "scale-up" lambda; otherwise, it sets the default to "pool-lambda". Since https://github.com/github-aws-runners/terraform-aws-github-runner/releases/tag/v7.0.0, we now process in batches, which means we are almost always doing actions in multiple rather than single (scale-up) and multiple (pool).
We really need to allign this with the https://github.com/github-aws-runners/terraform-aws-github-runner/releases/tag/v7.0.0 change