Repository navigation
Encode file paths when loading files in the source browser - #475
Merged
Merged
Conversation
loadFile put the archive path into the URL as-is, so a file name containing # or ? was cut short and failed to load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadFilein the source browser built/ui/api/browse/.../file/${path}without encoding the path, so a file nameda#b.txtrequested.../file/src/aand showed "Error loading file". Each segment is now passed throughencodeURIComponent. The browse endpoint already decodes encoded segments; the new test pins that for#,?,%and spaces.