Repository navigation
Withhold Composer archives still in cooldown - #469
Merged
Merged
Conversation
Cooldown only filtered the metadata. A composer.lock names the proxy's /files URL directly, so `composer install` fetched versions still inside the cooldown window without ever seeing the filtered metadata. npm already checks the publish time on tarball downloads. - Return the version's publish time with its dist URL, following the minified format's inheritance - Answer 404 for a version in cooldown before fetching its archive - Read the download lookup's metadata through ReadMetadata, so it has the same size limit as other metadata reads
andrew
approved these changes
Oct 14, 2026
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cooldown only filtered Composer metadata. A
composer.lockrecords the proxy's/composer/files/...URL, socomposer installfetched versions still inside the cooldown window without ever reading the filtered metadata. npm already checks publish time on tarball downloads (versionInCooldown).Changes
composerDistURLandfindDownloadURLFromMetadatareturn acomposerDistwith the URL, the dist type and the version's publish time. The time follows the minified format's field inheritance.handleDownloadanswers 404 for a version in cooldown before fetching its archive, using the existingshouldFilterVersion.ReadMetadata, so it has the same size limit as other metadata reads.Testing
TestComposerDownloadCooldown, which requests/files/...directly with a 3-day cooldown and minified metadata. Before the fix, the recent version and a version that inherits itstimeboth returned 200 and were fetched upstream. Now both return 404 without an upstream archive request, and an older version still downloads.go test -race ./internal/handler/...,go vetandgolangci-lintv2.13.1 pass.