Repository navigation
Enable storage retention for maven - #444
Merged
Merged
Conversation
Package rules use pkg:maven/{group}/{artifact} with the case as published. Keys without a group or with the group written as a path can never match and are refused. Files from the Gradle Plugin Portal fallback fall under the maven rule; the Gradle build cache isn't affected.
The mirror can't fetch Maven packages today (it passes group/artifact where the resolver wants group:artifact), so there's no mirror test.
Refs git-pkgs#306
andrew
approved these changes
Oct 12, 2026
andrew
left a comment
andrew
left a comment
Contributor
There was a problem hiding this comment.
Maven package rules match the stored PURLs, and the handler tests cover eviction, refetching, package exemptions, and Plugin Portal fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #306, builds on #428.
Registers maven for
storage.retention.Package rules use
pkg:maven/{group}/{artifact}with the case as published. Keys without a group, or with the group written as a path (org/apache/...), could never match and are refused at startup. Files from the Gradle Plugin Portal fallback fall under the maven rule. The Gradle build cache isn't affected and keeps its ownmax_age.The mirror can't fetch Maven packages today: it passes
group/artifactwhere the resolver wantsgroup:artifact. So there's no mirror test.