Repository navigation
Enable storage retention for npm - #440
Merged
Merged
Conversation
npm stores packages under the PURL purl builds from the full name, so package rules use the default mapping. Both pkg:npm/@babel/core and pkg:npm/%40babel/core work. Refs git-pkgs#306
The docs now say npm package rules match the name exactly, so pkg:npm/jsonstream doesn't cover JSONStream. The refetch, package rule and mirror tests were weaker than their names and now check what they claim. Refs git-pkgs#306
andrew
approved these changes
Oct 12, 2026
andrew
left a comment
andrew
left a comment
Contributor
There was a problem hiding this comment.
npm package rules match the production cache keys. The tests cover eviction, deletion queueing, refetching, scoped package exemptions, and mirrored tarballs.
andrew
approved these changes
Oct 12, 2026
andrew
left a comment
andrew
left a comment
Contributor
There was a problem hiding this comment.
The documentation conflict is resolved with the npm entry and the previously merged ecosystem entries preserved. This retains the change reviewed at #440 (review).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #306, builds on #428.
Registers npm for
storage.retention, so cached tarballs are evicted once nobody has downloaded them for the configured age.Package rules use the package name as purl writes it. Both
pkg:npm/@babel/coreandpkg:npm/%40babel/corework. Names match exactly, sopkg:npm/jsonstreamdoesn't coverJSONStream.Tests cover eviction and refetch, package rules for scoped and unscoped packages, and tarballs the mirror puts in the cache.