Write safer install instructions in readme - #14
Open
ZelphirKaltstahl wants to merge 1 commit into
Open
ZelphirKaltstahl wants to merge 1 commit into
ZelphirKaltstahl wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I just saw your project and when I saw
npm installI thought "Argh... This can be done in a safer way."The background is that with a plain
npm installany pre-install scripts of dependencies can run, and in bad cases simply nuke a user's home directory or install malware. You are not controlling all of your dependencies, and neither are you pinning one specific version of your dependencies inpackage.json, audited to not be harmful, so extra care is needed installing the dependencies.I have edited the readme to reflect this and install dependencies in a safer way. Your github workflow already does use
npm cithough not with the--ignore-scriptsflag, but then again that's not running on the user's machine anyway.