Skip to content

ci(security): OSTIF Now-tier — SHA pins, CodeQL JS, desktop CI, dependabot npm - #78

Merged
tonibergholm merged 1 commit into
mainfrom
ci/ostif-now-tier
Jul 18, 2026
Merged

tonibergholm merged 1 commit into
mainfrom
ci/ostif-now-tier

Conversation

@tonibergholm

Copy link
Copy Markdown
Member

Executes Now-tier todos T-2, T-3, T-4, T-5, T-26 from docs/audit/ostif-best-practices-audit.md (#76):

  • T-2 / G-029 — every action pinned to a full commit SHA with version comment; dtolnay/rust-toolchain gains an explicit toolchain: 1.96.1 input (version no longer rides the ref). Closes Scorecard alerts Disposition: secret env-var confidentiality boundary #6–chore(deps): bump chacha20poly1305 from 0.10.1 to 0.11.0 #13.
  • T-3 / G-028 — CodeQL matrix gains javascript-typescript (build-mode: none) for the desktop renderer.
  • T-4 / G-006 — new desktop CI job: npm ci → npm audit --audit-level=high → typecheck → vitest. Verified locally: 11/11 tests, 0 audit findings, clean typecheck.
  • T-5 / G-027 — dependabot npm ecosystem for apps/desktop (weekly, minor/patch grouped).
  • T-26 / G-035 — RUSTSEC-2024-0413 (atk) added to the audit ignore list beside its nine GTK3-family siblings, same GTK4 removal gate.

Settings changes applied separately (not in this diff): secret scanning + push protection ON, Dependabot alerts + security updates ON, private vulnerability reporting ON, ruleset now requires the four CI/CodeQL checks + up-to-date branches.

… job, dependabot npm, atk advisory

Executes the Now-tier todos from docs/audit/ostif-best-practices-audit.md:

- T-2 (G-029): pin every third-party action to a full commit SHA with a
  version comment (checkout v7.0.0, rust-toolchain 1.96.1 + explicit
  toolchain input since the version no longer rides the ref, rust-cache
  v2, codeql-action v4.37.1, audit-check v2). Dependabot keeps SHAs
  bumped. Closes Scorecard alerts #6-#13.
- T-3 (G-028): add javascript-typescript to the CodeQL matrix — the
  desktop renderer is where untrusted repo content crosses the Tauri
  IPC boundary into a WebView.
- T-4 (G-006): new desktop CI job — npm ci (verifies lockfile integrity
  hashes for the first time in CI), npm audit --audit-level=high,
  typecheck, vitest. Verified green locally (11/11 tests, 0 findings).
- T-5 (G-027): dependabot npm ecosystem for apps/desktop.
- T-26 (G-035): add RUSTSEC-2024-0413 (atk, GTK3-unmaintained family)
  to the audit ignore list with the same GTK4 removal gate — it was
  missing while its nine siblings were listed.
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@tonibergholm
tonibergholm merged commit 2c373d0 into main Jul 18, 2026
8 checks passed
@tonibergholm
tonibergholm deleted the ci/ostif-now-tier branch July 18, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants