Repository navigation
fix(audit): address RustSec issues #53–#68 - #70
Conversation
ReviewWhat I verified independently
Blocking: both red checks share one root causeVendoring turns glib from a registry dependency into a path dependency, and tooling stops treating it as third-party code:
Non-blocking suggestions
VerdictApproach is exactly right — backport the real fix, narrowly-scoped removal-gated exceptions, honest provenance. But it can't merge as is: Linux CI genuinely fails to build and CodeQL flags the vendored upstream code. Both need the small fixes above plus the |
What changed
glib0.18.5 and backport the upstream two-lineVariantStrItersoundness fix for RUSTSEC-2024-0429.[patch.crates-io]and document its provenance and removal condition.proc-macro-error, andurlpattern 0.3/ rust-unic dependency advisories.Why
Tauri 2's Linux WebKit/GTK stack remains pinned to GTK3-era crates, and
tauri-utilsremains pinned tourlpattern 0.3. Those informational maintenance advisories cannot be upgraded independently. Theglib::VariantStrIteradvisory is an actual soundness issue, so this PR backports the upstream fix instead of merely suppressing it. Cargo Audit matches package versions rather than patched source, so that advisory also remains in the audit exception list until Tauri adoptsglib >= 0.20.Impact
Linux desktop builds use the patched
glibimplementation. Product behavior and public APIs are otherwise unchanged. Every exception includes a concrete upstream upgrade condition for removal.Validation
cargo test --workspacecargo check --workspace --all-targetscargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningsglibfix plus provenance differCloses #53
Closes #54
Closes #55
Closes #56
Closes #57
Closes #58
Closes #59
Closes #60
Closes #61
Closes #62
Closes #63
Closes #64
Closes #65
Closes #66
Closes #67
Closes #68