Repository navigation
fix(demo): sharded-layout object check in run_protect_demo.sh - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44.
Problem
demo/run_protect_demo.shfailed on every run withFAIL: clone dropped object <aa>: its clone object-presence check predates P8's sharded loose-object layout (.sc/objects/<aa>/<rest>), so its one-level glob saw shard directories and[ -f ]was always false.Fix
One hunk: replace the flat per-object loop with the sorted
find .sc/objects -type fdiff between origin and clone — the exact idiom already used byrun_http_remote_demo.sh:107andrun_streaming_demo.sh:98. Deliberately a stronger assertion than the original (bidirectional store equality, not just A ⊆ B), anddiffprints the differing paths beforefailfires.Verification
RESULT:line, exit 0, zero residue.cargo testgreen (529+ tests, 0 failures).docs/superpowers/.Note (from final review, non-blocking): CLAUDE.md's Commands block doesn't list this demo — pre-existing gap, candidate for a follow-up docs commit now that the P7 proof passes again.