Repository navigation
feat(forge): private orgs from the admin CLI, and refuse Gitea's brace globs in branch protection - #336
Merged
Conversation
Codento Engine's Project host bootstrap creates its org as private; sc-forge hard-coded public, which would expose the org (and its member list) to every signed-in user after the migration (Engine ADR-0080, COD2-7139). The new --visibility flag takes Gitea's values and defaults to public as before.
Gitea's glob syntax also gives { and \ a meaning, so a rule like
{main,release} recreated from Gitea was stored as a literal branch name
that protects nothing. Such names are now refused like the other patterns.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tonibergholm
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps surfaced while moving Codento Engine's Project repositories from Gitea to sc-forge (Engine ADR-0080).
sc-forge admin org create --visibility public|limited|private. The default stays public. Engine's bootstrap creates its orgprojectsas private, as its Gitea bootstrap did. Until now the CLI hard-coded public, which would have exposed the org and its members to every signed-in user. Invalid values are refused.{or\are now refused like* ? [. Gitea 1.26.2's glob syntax gives meaning to* ? [ { \, so a Gitea rule like{main,release}was stored as a literal branch name and protected nothing. Existing stored rules still load and enforce.Proof:
e2e_achecks that a CLI-created private org reads back as private and that an invalid value errors.e2e_protectiongains a brace-glob refusal case.cargo test -p scl-forgepasses all 323 tests, and clippy (-D warnings) is clean.Reviewed with sol-loop: 1 round with gpt-6.1-sol on high. Sol verdict: approved
Created with Claude Opus 5.5 in T3 Code (Claude Code harness).