Skip to content

fix(deps): drop the unused aws-sdk-s3 sigv4a feature (RUSTSEC-2026-0387) - #314

Merged
tonibergholm-codento merged 1 commit into
mainfrom
chore/audit-rustsec-2026-0387
Oct 25, 2026
Merged

tonibergholm-codento merged 1 commit into
mainfrom
chore/audit-rustsec-2026-0387

Conversation

@tonibergholm-codento

@tonibergholm-codento tonibergholm-codento commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

crypto-bigint 0.5.5 reached us only through aws-sigv4 -> p256 -> elliptic-curve 0.13,
the SigV4a ECDSA signer. objio signs with plain SigV4 and never uses multi-region
access points, so the feature only added the vulnerable dependency (no patched
elliptic-curve 0.13 exists). Removing it drops crypto-bigint, p256, ecdsa and ~190
lockfile lines. A multi-region access point ARN would now fail with an SDK error.

Closes #309

Summary by CodeRabbit

  • Chores
    • Updated internal configuration for S3-related functionality. This change does not alter the features available to users or the behavior of the application. No changes to the user interface or workflows are included in this update.

crypto-bigint 0.5.5 reached us only through aws-sigv4 -> p256 -> elliptic-curve 0.13,
the SigV4a ECDSA signer. objio signs with plain SigV4 and never uses multi-region
access points, so the feature only added the vulnerable dependency (no patched
elliptic-curve 0.13 exists). Removing it drops crypto-bigint, p256, ecdsa and ~190
lockfile lines. A multi-region access point ARN would now fail with an SDK error.

Closes #309
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T06:14:35.762253Z b307690 PR opened
🔒 Security Review ✅ Completed 2026-10-25T06:16:41.208312Z b307690 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3d7f36b0-346c-47f9-8272-21cb4548f765
Commits

Reviewing files that changed from the base of the PR and between 241b29d and b307690.

Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1
  • crates/objio/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The aws-sdk-s3 dependency no longer enables the sigv4a feature. Its version, other features, and default-features = false setting remain unchanged.

Changes: S3 feature configuration

Layer / File(s) Summary
Remove the sigv4a feature
crates/objio/Cargo.toml
The aws-sdk-s3 dependency no longer enables sigv4a. Its other configuration is unchanged.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to b3076

The change is mergeable; the documented multi-region access-point limitation is intentional.

Architecture risk: Low · up to b3076

The change affects 1 system.

Changed systems: crates

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — crates (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in crates/objio/Cargo.toml: Removed sigv4a from the enabled aws-sdk-s3 features; the remaining dependency configuration is unchanged.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: removing the unused aws-sdk-s3 sigv4a feature to address the cited security issue.
Linked Issues check Passed The PR addresses #309 by removing the sigv4a feature from aws-sdk-s3 in crates/objio/Cargo.toml. The PR states that objio uses plain SigV4 and does not use multi-region access points, so the `cr…
Out of Scope Changes check Passed The reviewed change contains one dependency-feature alteration in crates/objio/Cargo.toml. It supports the remediation for #309 and matches the stated SigV4-only scope. No unrelated source or config…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The PR addresses #309 by removing the sigv4a feature from aws-sdk-s3 in crates/objio/Cargo.toml. The PR states that objio uses plain SigV4 and does not use multi-region access points, so the crypto-bigint 0.5.5 dependency path is no longer required. The reported trade-off is that multi-region access point ARNs fail with an SDK error. Cargo.lock is excluded from review, so the reported lockfile dependency removal cannot be independently verified, but the manifest change directly removes the feature that introduces the dependency path.

Full details: Out of Scope Changes check

Explanation

The reviewed change contains one dependency-feature alteration in crates/objio/Cargo.toml. It supports the remediation for #309 and matches the stated SigV4-only scope. No unrelated source or configuration changes are reported.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tonibergholm tonibergholm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drops an unused feature; audit green.

@tonibergholm-codento
tonibergholm-codento merged commit 28a8269 into main Oct 25, 2026
12 checks passed
@tonibergholm-codento
tonibergholm-codento deleted the chore/audit-rustsec-2026-0387 branch October 25, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUSTSEC-2026-0387: Multiple timing variability issues in operations intended to be constant-time

2 participants