Skip to content

chore: drop two workspace clippy allows, fix them at the source - #206

Merged
tonibergholm-codento merged 1 commit into
mainfrom
clippy-tight
Oct 19, 2026
Merged

tonibergholm-codento merged 1 commit into
mainfrom
clippy-tight

Conversation

@tonibergholm

@tonibergholm tonibergholm commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Closes the clippy allow-list item in ROADMAP.md (launch prep).

  • type_complexity: named aliases SealInput, SealedFile and WrapMap in protect.rs (reused by repo.rs and private.rs), plus two local aliases for a test fixture return and a test state table.
  • doc_lazy_continuation: one doc comment in replay.rs had a wrapped line starting with +, which markdown reads as a list item; reflowed.
  • too_many_arguments stays allowed (eight commit/snapshot-assembly and replay functions); the Cargo.toml comment and ROADMAP entry say why.

No behavior change. cargo clippy --workspace --all-targets -- -D warnings clean; cargo test --workspace 986 passed, 0 failed.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor

    • Streamlined internal handling of protected-file data across merge, publishing, and conflict processing. Runtime behavior is unchanged.
    • Reduced the workspace’s Clippy exceptions; one allowance remains.
  • Documentation

    • Corrected wording in conflict-path documentation.
    • Updated the roadmap to reflect completed lint cleanup.

type_complexity gets named aliases (SealInput, SealedFile, WrapMap, plus two
local ones) and doc_lazy_continuation was one reflowed doc comment.
too_many_arguments stays: eight commit/snapshot-assembly and replay functions
take their inputs one by one by design.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T14:59:34.047932Z 2b177d9 PR opened
🔒 Security Review ✅ Completed 2026-10-19T15:00:19.968479Z 2b177d9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 315913df-b987-4406-afbf-996ad1f910e4
📥 Commits

Reviewing files that changed from the base of the PR and between d61ea65 and 2b177d9.

📒 Files selected for processing: 7
  • Cargo.toml
  • ROADMAP.md
  • crates/repo/src/merge.rs
  • crates/repo/src/private.rs
  • crates/repo/src/protect.rs
  • crates/repo/src/replay.rs
  • crates/repo/src/repo.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The change adds aliases for protected-file tuple and map types, updates their declarations and call sites, and removes two Clippy allowances. It also updates the roadmap, adjusts a test type alias, and corrects a replay comment.

Changes: Clippy type-complexity cleanup

Layer / File(s) Summary
Protected-file type aliases
crates/repo/src/protect.rs, crates/repo/src/private.rs, crates/repo/src/repo.rs, crates/repo/src/merge.rs
Added aliases for protected-file sealing types and used them in encryption, publishing, merge processing, conflict-state materialization, and test declarations. The tuple shapes and sealing behavior remain unchanged.
Clippy allowlist and documentation updates
Cargo.toml, ROADMAP.md, crates/repo/src/replay.rs
Removed the type_complexity and doc_lazy_continuation allowances, updated the roadmap entry, and corrected a duplicate character in replay conflict-path documentation.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2b177

The reviewed changes do not establish an actionable behavior or operational risk. Mergeability risk is minimal.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: it identifies the removal of two workspace Clippy allows and the corresponding source fixes.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. (2 skipped: 2 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tonibergholm-codento tonibergholm-codento left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required checks green on 2b177d9; Codex and CodeRabbit raised no findings.

@tonibergholm-codento
tonibergholm-codento merged commit b8c0ed9 into main Oct 19, 2026
9 checks passed
@tonibergholm
tonibergholm deleted the clippy-tight branch October 19, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants