Repository navigation
chore: drop two workspace clippy allows, fix them at the source - #206
Merged
Merged
Conversation
type_complexity gets named aliases (SealInput, SealedFile, WrapMap, plus two local ones) and doc_lazy_continuation was one reflowed doc comment. too_many_arguments stays: eight commit/snapshot-assembly and replay functions take their inputs one by one by design. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tonibergholm-codento
approved these changes
Oct 19, 2026
tonibergholm-codento
left a comment
Collaborator
There was a problem hiding this comment.
Required checks green on 2b177d9; Codex and CodeRabbit raised no findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the clippy allow-list item in ROADMAP.md (launch prep).
type_complexity: named aliasesSealInput,SealedFileandWrapMapinprotect.rs(reused byrepo.rsandprivate.rs), plus two local aliases for a test fixture return and a test state table.doc_lazy_continuation: one doc comment inreplay.rshad a wrapped line starting with+, which markdown reads as a list item; reflowed.too_many_argumentsstays allowed (eight commit/snapshot-assembly and replay functions); the Cargo.toml comment and ROADMAP entry say why.No behavior change.
cargo clippy --workspace --all-targets -- -D warningsclean;cargo test --workspace986 passed, 0 failed.🤖 Generated with Claude Code
Summary by CodeRabbit
Refactor
Documentation