Repository navigation
fix(demo): read file modes with GNU stat first - #201
Merged
Merged
Conversation
The comment said portable across BSD and GNU, but on GNU stat 'stat -f' means filesystem status and succeeds, so the %Lp form never failed over to -c and the mode check saw filesystem info. Try the GNU form first; on macOS 'stat -c' is invalid and falls through to 'stat -f %Lp'. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tonibergholm-codento
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
demo/run_tls_demo.shfailed on Linux at its key.pem mode check.file_modetriedstat -f "%Lp"first; on GNU stat-fmeans filesystem status and exits 0, so thestat -cfallback was never reached and the check compared filesystem info with600. The GNU form now goes first; on macOSstat -cis invalid and falls through to the BSD form. The demo now endsRESULT: okon Linux. No code change.🤖 Generated with Claude Code
Summary by CodeRabbit