Skip to content

test(repo): a bucket serve session refuses GetObjects and stays usable - #193

Merged
tonibergholm-codento merged 1 commit into
mainfrom
p37a-tests
Oct 19, 2026
Merged

tonibergholm-codento merged 1 commit into
mainfrom
p37a-tests

Conversation

@tonibergholm

@tonibergholm tonibergholm commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Closes one of the P37a test gaps deferred earlier. A bucket-backed sc serve --store session answers GetObjects with a typed refusal (by-id reads exist only for partial clones, which bucket remotes refuse, ADR-0046/0047) and keeps serving: the test asserts the error and then a ListRefs on the same session. The other items on that list (reply-cap wiring, hostile-reply bounds, duplicate not-sent ids, round trip) turned out to be covered already by readonly_session_serves_get_objects_and_caps_the_reply and the stdio_transport tests, so no change there.

Test only. cargo clippy --workspace --all-targets -D warnings clean; the new test passes.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Added coverage confirming that unsupported object retrieval returns an error without disrupting the session or subsequent reference listing.

ADR-0047/0046: by-id reads exist only for partial clones, which bucket
remotes refuse. The refusal had no test; the reply-cap, hostile-reply and
round-trip cases are already covered.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T08:43:17.409421Z 2ce8f08 PR opened
🔒 Security Review ✅ Completed 2026-10-19T08:43:35.667959Z 2ce8f08 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c12571d-9ad5-4a77-b090-ac622fb096f7
📥 Commits

Reviewing files that changed from the base of the PR and between ada64b0 and 2ce8f08.

📒 Files selected for processing: 1
  • crates/repo/src/wire.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

An integration test seeds a bucket-backed serve session, checks that GetObjects returns a by-id-related error, confirms that ListRefs succeeds afterward, and closes the session and cleans up temporary data.

Changes: Bucket Serve Request Handling

Layer / File(s) Summary
Request handling and cleanup
crates/repo/src/wire.rs
The integration test checks the GetObjects error response and a successful ListRefs request afterward. It then closes the session and cleans up temporary repository data.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2ce8f

The new test covers continued service after a refused request. No issue identified here prevents merging after normal checks.

### Architecture Summary

Architecture risk: 🔵 Low · up to 2ce8f

The change affects 1 system.

Changed systems: crates

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — crates (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in crates/repo/src/wire.rs: Added an integration test covering the bucket server’s GetObjects refusal, a successful ListRefs after that failed request, and session and repository cleanup.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: it adds a repository test that verifies a bucket serve session refuses GetObjects and remains usable.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tonibergholm-codento
tonibergholm-codento merged commit 0737bb6 into main Oct 19, 2026
8 checks passed
@tonibergholm
tonibergholm deleted the p37a-tests branch October 19, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants