Repository navigation
test(repo): a bucket serve session refuses GetObjects and stays usable - #193
Merged
Merged
Conversation
ADR-0047/0046: by-id reads exist only for partial clones, which bucket remotes refuse. The refusal had no test; the reply-cap, hostile-reply and round-trip cases are already covered. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tonibergholm-codento
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes one of the P37a test gaps deferred earlier. A bucket-backed
sc serve --storesession answersGetObjectswith a typed refusal (by-id reads exist only for partial clones, which bucket remotes refuse, ADR-0046/0047) and keeps serving: the test asserts the error and then aListRefson the same session. The other items on that list (reply-cap wiring, hostile-reply bounds, duplicate not-sent ids, round trip) turned out to be covered already byreadonly_session_serves_get_objects_and_caps_the_replyand thestdio_transporttests, so no change there.Test only.
cargo clippy --workspace --all-targets -D warningsclean; the new test passes.🤖 Generated with Claude Code
Summary by CodeRabbit