Skip to content

docs: mark two stale deferred roadmap entries resolved - #188

Merged
tonibergholm-codento merged 2 commits into
mainfrom
roadmap-stale
Oct 19, 2026
Merged

tonibergholm-codento merged 2 commits into
mainfrom
roadmap-stale

Conversation

@tonibergholm

@tonibergholm tonibergholm commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Two Deferred entries described gaps that are already closed: the rebase_continue .theirs sweep now skips tracked paths, and Repo::rewrap refuses on a partial clone. Docs only.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified that cleanup during rebase_continue is only partially fixed: tracked paths are skipped, but an untracked foo.txt.theirs may still be deleted in text-only conflicts.
    • Updated the partial-clone sc rewrap roadmap item to note that it is refused for partial clones and that a paths-only or streaming rebuild remains a possible follow-up.

…entries resolved

Both were fixed (P37c, P37) but still listed as open under Deferred.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T03:52:37.021892Z b529ccf New commits
🔒 Security Review ✅ Completed 2026-10-19T03:52:55.732950Z b529ccf New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5b96812d-e1bc-4b82-a646-93dbf936aa54
📥 Commits

Reviewing files that changed from the base of the PR and between fc60d64 and b529ccf.

📒 Files selected for processing: 1
  • ROADMAP.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The roadmap now describes a remaining rebase_continue sidecar-cleanup case and records that Repo::rewrap refuses partial clones. It also retains paths-only or streaming rewrapping as a possible follow-on.

Changes: Roadmap status updates

Layer / File(s) Summary
Record deferred issue status
ROADMAP.md
The roadmap notes that cleanup skips paths tracked by the completion parent tree, but can still delete an untracked {path}.theirs file in a text-conflict case. It also records the partial-clone refusal in Repo::rewrap and a possible paths-only or streaming follow-on.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b529c

The roadmap updates reflect the supplied implementation evidence and leave the rewrapping follow-on clearly deferred. No merge-blocking behavior change is identified.

### Architecture Summary

Architecture risk: 🔵 Low · up to b529c

The change affects 1 system.

Changed systems: ROADMAP.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — ROADMAP.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in ROADMAP.md: The rebase_continue entry now says cleanup skips paths tracked by the completion parent tree, but still lacks a non-text-kind gate; a text conflict can therefore lead the sweep to delete an untracked {path}.theirs file. The prior entry described blind unlinking without either the tracked-path guard or the non-text-kind gate.
  • observed — Modified behavior in ROADMAP.md: The sc rewrap entry now records that Repo::rewrap refuses partial clones through refuse_on_partial; previously it described whole-plaintext loading without a partial-clone refusal. A paths-only or streaming rebuild remains deferred.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the documentation change and the two deferred roadmap entries updated. It matches the pull request objectives.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c2a9b7bb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ROADMAP.md Resolved
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@tonibergholm-codento
tonibergholm-codento merged commit 670c9e5 into main Oct 19, 2026
8 checks passed
@tonibergholm
tonibergholm deleted the roadmap-stale branch October 19, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants