Repository navigation
fix(repo): refuse private branches on a partial clone (ADR-0048 q10) - #180
Merged
Merged
Conversation
…w NotFound Creating a private branch on a partial clone succeeded, and switching to it failed with a raw NotFound because opening one flattens and seals whole trees. Both are now refused with the explicit partial-clone message. Resolves ADR-0048 open question 10. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tonibergholm-codento
approved these changes
Oct 17, 2026
tonibergholm-codento
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed; checks green on 3f33f78.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves ADR-0048 open question 10, raised in the P37b-i review: private branches on a partial clone.
A probe showed
sc branch --privatesucceeds on a partial clone, and switching to the new branch then fails with a rawNotFound, because opening a private branch flattens and seals whole trees. Following the 37b-i pattern, creating one and switching to one are now refused up front with the explicit partial-clone message (sc backfill --alllifts it). Nothing is touched before the refusal.Changes
branch_privateand the private arm ofswitch_with_identitycallrefuse_on_partial.private_branches_are_refused_on_a_partial_clonecovers creation and switching to a manifest tip that reached the clone another way, and asserts HEAD and the working tree are untouched.CLAUDE.mdrefusal list is updated.Verification
cargo fmt --check,clippy -D warnings,cargo test --workspace --all-targetsgreen locally (619scl-repolib tests).🤖 Generated with Claude Code
Summary by CodeRabbit
sc backfill --all.