Skip to content

ci(deps): rustls 0.23.46 (RUSTSEC-2026-0346..0349) and codeql-action 4.38.3 - #174

Merged
tonibergholm merged 2 commits into
mainfrom
deps-rustls-codeql
Oct 15, 2026
Merged

tonibergholm merged 2 commits into
mainfrom
deps-rustls-codeql

Conversation

@tonibergholm

@tonibergholm tonibergholm commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

What

Verification

  • cargo fmt --all --check: clean
  • cargo test -p scl-tlsio: 12 passed
  • cargo check --workspace: clean

Summary by CodeRabbit

  • Chores
    • Refreshed the automated security analysis and reporting workflows. These maintenance updates do not change app functionality or user-facing behavior. No new features or changes to the experience are included in this update.

rustls 0.23.46 fixes RUSTSEC-2026-0346, -0347, -0348 and -0349, which
were published on 2026-10-14 against 0.23.45. tlsio depends on rustls
directly, and the AWS SDK pulls it in through objio. Only Cargo.lock
changes.

codeql-action init, analyze and upload-sarif move to 4.38.3 in one
commit. analyze rejects config written by a different init version, so
Dependabot's separate init and analyze PRs (#171, #169) cannot pass on
their own. This replaces both.
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f8eb13ec-7ea6-460d-ab1d-1d0e8892c939
📥 Commits

Reviewing files that changed from the base of the PR and between f5879bb and 32fba61.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c5254502-3225-4984-803b-1775031ec1e0
📥 Commits

Reviewing files that changed from the base of the PR and between 5104c6b and f5879bb.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 2
  • .github/workflows/codeql.yml
  • .github/workflows/scorecard_analysis.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The CodeQL initialization, analysis, and SARIF upload workflow steps now use action version v4.38.3 instead of v4.38.2. Their other described configuration remains unchanged.

Changes: CodeQL action updates

Layer / File(s) Summary
Update CodeQL action versions
.github/workflows/codeql.yml, .github/workflows/scorecard_analysis.yml
The init and analyze steps, and the SARIF upload step, now use v4.38.3. The SARIF input remains results.sarif.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f5879

The PR updates the Rustls lockfile resolution and advances the CodeQL workflow actions together. The inspected changes show no concrete merge-blocking risk.

### Architecture Summary

Architecture risk: 🔵 Low · up to f5879

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/codeql.yml: The init and analyze steps were updated from the v4.38.2 commit to v4.38.3; their configuration and language/build-mode inputs are unchanged.
  • observed — Modified behavior in .github/workflows/scorecard_analysis.yml: The code-scanning upload step updates github/codeql-action/upload-sarif from v4.38.2 to v4.38.3.
Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies both primary changes: the rustls security update and the CodeQL Action update.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T08:08:22.321500Z 32fba61 New commits
🔒 Security Review ✅ Completed 2026-10-15T08:09:14.734467Z 32fba61 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tonibergholm
tonibergholm merged commit 2a4d476 into main Oct 15, 2026
9 checks passed
@tonibergholm
tonibergholm deleted the deps-rustls-codeql branch October 15, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants