Skip to content

Signature index v2 edge cases from the #265 review: migration retry on signature-free ingest, reindex vs concurrent serve ingest #270

Closed

Description

@tonibergholm-codento

Two P2 Codex notes on #265 left for a follow-up (no trust-gate impact; both are fail-safe):

  1. If the startup legacy migration (.sc/signatures -> .sc/signatures.v2) failed transiently and a later incoming pack contains NO signatures, ingest does not retry the migration, so legacy entries stay unread until the next open/ingest that does. Retry migration on every ingest (cheap when already migrated), or on the next Repo::open.
  2. signatures::reindex is not locked across its scan; if a serve-path ingest targets the same destination during a clone's post-clone reindex, concurrent appends can be lost. Take the index lock around the rebuild's write phase (or merge appends made since the scan started).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions