Skip to content

Signature index: key by (target, signer) so honoring a drop cannot be crowded out by valid signatures from attacker keys #257

Closed

Description

@tonibergholm-codento

Follow-up from #254 (tombstone delivery, #230).

Since #254 signatures::index_incoming and reindex index a signature only when its target is held and it verifies under the key it names (drop digest for tombstones), so forged or dangling signatures never enter the index. A signature made by a different key the attacker controls is still valid, so a writer to a shared remote can index more than MAX_SIG_READS (256) such signatures over a predictable tombstone id (it depends only on snapshot and transcript id) ahead of the real one. tombstone_honored reads the index in order and stops at 256, so the trusted signer's signature is never reached and the drop stays inert on every peer that ingests the junk. It is a denial of the drop, never an honored one.

Proposed: key the index per (target, signer) with dedupe, so a signer occupies one slot per target and honoring is a lookup over the trusted signers only (index lines gain the signer; old lines parse as unknown and are resolved by reading the object; reindex rebuilds). Honoring then reads at most one signature per trusted signer.

Related: ADR-0038 addendum (#230), THREAT-MODEL drop tombstones.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions