Zero token counts for empty transcripts and README alignment#43
Open
Zero token counts for empty transcripts and README alignment#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
llm_tokens_by_modelcolumn aligns with other columns for readability.Description
utils/tokens.pysotokens_by_modelreturns zeros for every model whentext.strip()is empty and keepLLM_TOKEN_MODELS-based mapping.schedulers/transcription.pyto computetoken_counts = tokens_by_model(raw_text)using the rawparse_text(result)output and then replace emptytextwith the friendly fallback string before persisting results.llm_tokens_by_model=token_countson both successful and failed updates inupdate_transcriptioncalls.README.mdspacing for thellm_tokens_by_modelJSON column to align with other schema columns.Testing
Codex Task