[동원] kakao 인턴 코드리뷰 요청 #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimJinHye0n
reviewed
Jul 14, 2021
| selected += 1 | ||
| while arr[selected] == 0: | ||
| selected += 1 | ||
| if arr[selected] != 0: |
Collaborator
There was a problem hiding this comment.
while문 어차피 탈출해서 따로 조건 안줘도 되지 않을까요?
KimJinHye0n
reviewed
Jul 14, 2021
| def solution (n,k,cmd): | ||
| selected = k | ||
| stack = [] | ||
| board = [i+1 for i in range(n)] |
Collaborator
There was a problem hiding this comment.
board 사용하는 구간이 없는거 같습니다
Owner
Author
There was a problem hiding this comment.
앗 그렇네요ㅜㅜ 근데 저는 왜 안되는지가 궁금..
Collaborator
There was a problem hiding this comment.
저는 테스트 3개만 통과해서 왜그런지 모르겠네요....
Owner
Author
There was a problem hiding this comment.
ㅋㅋㅋㅋ 저도 정확도 테스트는 대여섯개는 맞아요 ㅜㅜ 어렵군.. 오늘 이놈이다!
KimJinHye0n
reviewed
Jul 16, 2021
| for item in cmd: | ||
| # print(item) | ||
| # print(arr, selected, stack) | ||
| if len(item) == 3: |
Collaborator
There was a problem hiding this comment.
반례 찾아왔습니다 "U 14" 이런식으로도 들어올 수 있다고 하네요
Owner
Author
There was a problem hiding this comment.
아아 맞네요!! >= 바꾸니깐 정확성 다 맞습니다 진현님 짱 😍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3번 요청드립니다 ㅜㅜ 어젯밤부터 하는데 답이 안나오네요.. 어디가 잘못된걸까요