Repository navigation
Conversation
- Add `aria-label` and `title` to the icon-only trash button for screen reader accessibility - Set `type="button"` to prevent unintended form submissions - Add `FOCUS_RING_CLASS` for improved keyboard navigation visibility - Wrap deletion logic in a `window.confirm` dialog to prevent accidental data loss Co-authored-by: giauphan <122676967+giauphan@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Update `@modelcontextprotocol/sdk` and `compression` versions in `package.json` - Override specific vulnerable dependencies (`proxy-addr`, `brace-expansion`, `@grpc/grpc-js`) in `package.json` overrides to address critical and high severity vulnerabilities - Update lock file by reinstalling packages Co-authored-by: giauphan <122676967+giauphan@users.noreply.github.com>
1 participant
💡 What: Improved the UX and accessibility of the preset deletion button in the Wiki configuration panel. Added an
aria-label, ensured it has atype="button", applied focus ring classes, and added a confirmation dialog before deleting.🎯 Why: Icon-only buttons for destructive actions are easy to misclick and invisible to screen readers without ARIA labels. Adding a confirmation dialog prevents accidental data loss.
♿ Accessibility: Added an explicit
aria-label="Delete selected preset"and improved keyboard focus visibility.PR created automatically by Jules for task 2289067786989923622 started by @giauphan