Repository navigation
Conversation
- Added `window.confirm` to prevent accidental deletion of Wiki presets. - Added explicit `aria-label` for screen reader accessibility. - Set `type="button"` to prevent form submission side effects. - Applied existing `FOCUS_RING_CLASS` to ensure keyboard navigation visibility. Co-authored-by: giauphan <122676967+giauphan@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Updated packages across the workspace to address security vulnerabilities flagged by the `pnpm audit` checks. Vulnerabilities addressed: - `@modelcontextprotocol/sdk` to 1.31.0 - `brace-expansion` to 2.1.6 - `compression` to 1.8.2 - `firebase-admin` to 14.4.0 - `proxy-addr` to 2.0.8 - `@grpc/grpc-js` to 1.14.5 Co-authored-by: giauphan <122676967+giauphan@users.noreply.github.com>
Updated packages across the workspace to address security vulnerabilities flagged by the `pnpm audit` checks. Vulnerabilities addressed: - `@modelcontextprotocol/sdk` to >=1.31.0 - `brace-expansion` to >=2.1.6 - `compression` to >=1.8.2 - `firebase-admin` to >=14.4.0 - `proxy-addr` to >=2.0.8 - `@grpc/grpc-js` to >=1.14.5 Co-authored-by: giauphan <122676967+giauphan@users.noreply.github.com>
…ockfile Updated packages across the workspace to address security vulnerabilities flagged by the `pnpm audit` checks using overrides. Vulnerabilities addressed: - `@modelcontextprotocol/sdk` to >=1.31.0 - `brace-expansion` to >=2.1.6 - `compression` to >=1.8.2 - `proxy-addr` to >=2.0.8 - `@grpc/grpc-js` to >=1.14.5 Co-authored-by: giauphan <122676967+giauphan@users.noreply.github.com>
💡 What
Added a confirmation dialog and improved accessibility for the "Delete Preset" icon-only button in the
WikiViewcomponent.🎯 Why
Destructive actions (like deleting saved profiles/presets) without confirmation can lead to accidental data loss. Furthermore, bare icon buttons without ARIA labels are inaccessible to screen readers, and lacking focus rings makes keyboard navigation difficult. This micro-UX improvement solves these issues without requiring any new dependencies or custom CSS.
📸 Before/After
Before: Clicking the trash icon instantly deleted the preset. No focus state or screen reader label.
After: Clicking prompts a
window.confirmdialog. The button is reachable via tab key with a clear focus ring, and provides an accessible name for screen readers.♿ Accessibility
aria-label="Delete selected preset"to the bare icon button.FOCUS_RING_CLASSfor clear keyboard focus indicators.type="button"to ensure it doesn't accidentally submit any surrounding forms in the future.PR created automatically by Jules for task 9636282995866369522 started by @giauphan