Repository navigation
ci(fork): a pull request closes no issue by keyword - #538
Merged
Merged
Conversation
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
force-pushed
the
ci/closing-keyword-guard
branch
from
October 22, 2026 12:24
8265d11 to
6b82045
Compare
QuentinBisson
marked this pull request as ready for review
October 22, 2026 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub closes the issue a closing keyword names in a pull request's description or in a commit it lands, upstream issues included. A ledger description quoted an upstream pull request's closing line for agent-substrate#2555 verbatim, and that issue was closed when the ledger pull request merged.
Change
A check fails a pull request whose title, description or commits pair a closing keyword (close, fix, resolve and their forms, any case) with an issue reference (
#<n>,<owner>/<repo>#<n>or an issues or pull URL), naming the line. It re-runs when the description is edited. Fixture runs cover the quoted case, cross-repository references, URLs, and words that only contain a keyword.