Repository navigation
Conversation
agentgateway 2.5.0 is the stable of v2.5.0-rc.4 on the same commit: the 2.5.0-rc.2 the line ran, plus every address of the gateway counted local for a tcp rule (giantswarm/agentgateway-upstream#108) and a policy denial answered 403 naming the destination and where it is allowed (giantswarm/agentgateway-upstream#109). A stable Substrate runs a stable agentgateway.
Member
Author
|
Replaced by #488, whose commit message carries no PR references (AGENTS.md). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 1.16.0 candidates run agentgateway
2.5.0-rc.2, a release candidate. Every stable Substrate before them ran a stable agentgateway, so 1.16.0 would be the first stable on a candidate dataplane.Proposed solution
Pin agentgateway
2.5.0, the stable ofv2.5.0-rc.4(913dbe92):2.5.0-rc.2plustcprule403with a status line and a body naming the destination and where it is allowedThe pin moves together in
.circleci/config.yml,charts/substrate/values.yamland the e2e's agentgateway component, by digestsha256:e48f9d4f….hack/verify/agentgateway-image.shpasses. FORK.md and the 1.15 → 1.16 upgrade notes now name 2.5.0.Acceptance criteria
run-testsandgovulncheckgreenv1.16.0candidate passes agentlab'ssubstrate-step-testfrom the released platform's Substrate: the conversation resumes, the durable volume is intact, and a new conversation starts on the golden. The candidate is promoted to1.16.0only after that.Before this pin,
v1.16.0-rc.3(on2.5.0-rc.2) passed the same step check from 1.13.1, all 8 stages.