Avoid MC connection in login command#3283
Open
pipo02mix wants to merge 1 commit into
Open
Conversation
1 task
stone-z
reviewed
Jul 16, 2026
|
|
||
| To use option 2, users must be allowed to read the resources above on the management cluster. The built-in `read-all` role covers this, but it grants read access to essentially every resource on the management cluster — far more than logging in requires. **We recommend granting a dedicated, minimal role instead**, so that logging in to workload clusters does not imply broad read access to the management cluster. Use `read-all` only if your users already have (and you have an RBAC plan for) general management cluster access. | ||
|
|
||
| The following `ClusterRole` (for the cluster-scoped `Organization` lookup) plus `Role` (for the per-organization resources) grant exactly what `kubectl gs login` needs. Bind them to your users or their OIDC group, and create one `Role`/`RoleBinding` per organization namespace they should be able to reach: |
Contributor
There was a problem hiding this comment.
When should a customer use a ClusterRole versus a Role? (Guessing: one customer might prefer users know about all Organizations, whereas another might prefer users know about the kubeadm resources only in one Organization?)
Contributor
Author
There was a problem hiding this comment.
yeah I am adding some improvements in kubectl gs login to avoid org read permission at all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/37183