[teemow]

Fixes #1795

The supervisor loop filed two of its own inner-loop states as decisions for the guide's person. This PR routes them inside the loop, and drops the guide skill's assumption that a push notification reaches the person's phone.

Used-up review rounds no longer reach the person

• When no change-request round is left (supervisor.reviewRounds) and the worker parks again on the head the last review asked changes on, the loop now wakes the worker with a rework message (supervisor.rework). It is told once for each such park, with a key per park. Once the worker pushes a green new head, it gets the merge go as before. No "Merge … or have it reworked?" note is filed any more.
• If an escalation an earlier loop filed was never answered, it no longer holds or untracks its pull request: the rounds go on. An answered one still counts. A release is the merge go for its head, and any other answer goes to the worker word for word, as before.
• An approved head followed by more commits still gets a new review, and that path never escalates. There is a regression test for the full approve → new head → changes requested → re-park sequence.

A mid-task agents.problem is a finding, not a decision

• An unpaired, unforwarded agents.problem is no longer sent to classify, which used to produce "Decide what … does next about its problem (unclassified)?".
• If it names an issue URL, it is already filed and nothing more happens.
• If it names none, it goes to the guide's queue to file in its owning repository (supervisor.file, "no decision"). The agent keeps its task, and the classifier never sees it.
• agents.report without a done, and a park on nothing, are still classified as before.

Guide skill

• Removed "goes to the person's phone with PushNotification".
• New rule: each GUIDE DECISION/GUIDE WAITING, and each decision guide next serves, is asked in the question dialog of the conversation the person reads. It is asked one at a time, without waiting for the person to ask. A note that is work (a problem to file) is carried out, not put to the person.
• A plugin test makes sure no shipped skill mentions a phone or PushNotification, and that the guide skill contains the new rule.

Tests

• go test ./internal/superloop ./plugin ./cmd: ok
• golangci-lint run ./internal/superloop/... ./cmd/... ./plugin/...: 0 issues

Written by an agent (a desk worker session).

🤖 Generated with Claude Code

https://claude.ai/code/session_01MK2zsbH97romAFxJkeYUXg

[teemow]

Review: changes requested
Head reviewed: 714510ea98108dc2f701a749feb599636f8ba4ef

CI evidence: gh pr checks 1828 --repo giantswarm/beekeeper --watch --fail-fast exited 0 with every reported check passing. The commit check-runs and combined status APIs confirm these results belong to the exact reviewed head. Platform tests and vet passed: https://github.com/giantswarm/beekeeper/actions/runs/41253564194 . Pre-commit passed: https://github.com/giantswarm/beekeeper/actions/runs/41253564224 . GitHub also reports successful CircleCI statuses, including go-build (https://circleci.com/gh/giantswarm/beekeeper/20943) and test-envtest (https://circleci.com/gh/giantswarm/beekeeper/20947). No CircleCI login or token was used. No local builds, tests, or lint runs were repeated.

The rework transition, continued tracking of unanswered legacy escalations, and guide-dialog instructions address the main cases in #1795. One blocking routing gap remains:

• [P2] cmd/supervisorloop.go:1203-1208: do not require an existing issue/PR to route an unfiled mid-task finding. agentRef only succeeds for a roster agent with a parked reference, serve record, or issue/PR URL in its task; the fallback likewise only accepts an issue/PR reference. A running agent with a general task can legitimately report, for example, “build slot queue gave up, owning repository giantswarm/beekeeper”, without an existing issue URL. This now produces KindFile, but toFile returns “problem names no issue or pull request” before creating a note. The pass only prints SUPERVISOR FILE FAILED; the finding never reaches the guide or supervisor and retries cannot resolve the missing reference. This leaves precisely the capacity/defect findings the issue asks to route stranded. Provide a durable filing/handoff route based on the owning repository (or another explicit fallback that does not require an already-existing issue/PR), and cover a mid-task problem from an agent whose task and serve record contain no issue/PR reference. This finding follows directly from the planner and early-return path; no local check was necessary.

Written by an agent (independent desk review, round 1).