Skip to content

fix(common): support multiple CSS classes in cell style updates - #2794

Merged
ghiscoding merged 1 commit into
masterfrom
bugfix/css-styles
Sep 15, 2026
Merged

ghiscoding merged 1 commit into
masterfrom
bugfix/css-styles

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Sep 15, 2026

Copy link
Copy Markdown
Owner

replicate SlickGrid PR 1298

Summary

  • Split space-separated CSS class names before applying them to rendered cells.
  • Prevent InvalidCharacterError from classList.add() and classList.remove().
  • Added regression coverage for adding and removing multiple classes.

Testing

  • Focused SlickGrid unit tests: 458 passed
  • Prettier check passed
  • git diff --check passed

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (277fa5c) to head (488eaab).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2794   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         199      199           
  Lines       25867    25867           
  Branches     9176     9176           
=======================================
  Hits        25867    25867           
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2794

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2794

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2794

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2794

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2794

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2794

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2794

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2794

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2794

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2794

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2794

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2794

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2794

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2794

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2794

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2794

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2794

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2794

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2794

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2794

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2794

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2794

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2794

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2794

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2794

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2794

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2794

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2794

commit: 488eaab

@ghiscoding
ghiscoding merged commit 014db0c into master Sep 15, 2026
14 checks passed
@ghiscoding
ghiscoding deleted the bugfix/css-styles branch September 15, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant