Skip to content

SPTECH-674: add meeting_point_address to tour options - #130

Merged
kingaM merged 1 commit into
mainfrom
SPTECH-674-meeting-point-address
Oct 13, 2026
Merged

kingaM merged 1 commit into
mainfrom
SPTECH-674-meeting-point-address

Conversation

@kingaM

@kingaM kingaM commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Documents the new optional meeting_point_address on tour options and clarifies that meeting_point is the supplier's free-text description.

Implementation: getyourguide/public-partner-api#2155. Merge after it is deployed.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kingaM
kingaM requested a balanced review from Copilot October 12, 2026 11:02
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2900416e-cc07-4fef-902a-dd2219b8811a

📥 Commits

Reviewing files that changed from the base of the PR and between 2d98799 and c09b2d8.


📒 Files selected for processing (1)
  • spec/components/schema/option.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Summary

Risk Score: Normal - Addressing the comments needed

Updated the TourOption API schema. The meeting_point description now identifies it as supplier-provided free-text instructions in the requested language. Added the meeting_point_address string property with a description and example address.

This documents the API contract. It does not implement runtime behavior.

📝 Summary

Walkthrough

The TourOption schema clarifies the meeting point instructions and adds a meeting point address property.

Changes

Tour option schema

Layer / File(s) Summary
Meeting point fields
spec/components/schema/option.yaml
The meeting_point description now specifies supplier-provided free-text instructions in the requested language. The schema adds a meeting_point_address string property with a description and example address.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Feature

Suggested labels: coderabbit-risk:normal


Merge Risk: ⚪ Minimal · up to c09b2

No actionable schema issue is established. Confirm the API implementation is deployed before merging, as the PR author requested.

Pre-merge checks | Passed 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Description check Passed The description directly documents the new optional meeting_point_address field and the clarified meeting_point behavior. It also states the implementation dependency and merge condition.
Title check Passed The title clearly identifies the main change: adding meeting_point_address to tour options.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@kingaM
kingaM marked this pull request as ready for review October 12, 2026 11:02
@kingaM
kingaM requested a review from a team as a code owner October 12, 2026 11:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The schema change is valid, focused, and accurately documents the new optional field.

0 open findings

What changed in this PR

Documents the optional meeting-point address field for tour options and clarifies the existing meeting-point semantics.

Changes:

  • Adds meeting_point_address with a description and example.
  • Clarifies that meeting_point is supplier-provided localized free text.
File Description
spec/​components/​schema/​option.yaml Updates the TourOption meeting-point schema documentation.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@clue-gyg clue-gyg removed the risk:low label Oct 12, 2026
@gyg-pr-tool
gyg-pr-tool Bot requested a review from pstarritt-gyg October 12, 2026 11:03
@kingaM
kingaM merged commit a3dfb62 into main Oct 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants